Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try apply yaml in best efforts #223

Merged
merged 1 commit into from
Jun 27, 2022
Merged

try apply yaml in best efforts #223

merged 1 commit into from
Jun 27, 2022

Conversation

xuzhenglun
Copy link
Contributor

@xuzhenglun xuzhenglun commented Jun 7, 2022 •
edited
Loading

What this PR does / why we need it:

  1. When I apply CR with it's CRD, an error like resource <Kind> is not found will return.
  2. In fact, kubectl will try its best efforts to apply YAMLs. In the progress, maybe CRDs have not been established and an error could return. But in the next retry, all YAMLs can be applied successfully.

ref: https://github.com/kubernetes/kubectl/blob/master/pkg/cmd/apply/apply.go#L438

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Additional documentation:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot requested a review from johnsonj June 7, 2022 12:04
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot requested a review from mengqiy June 7, 2022 12:04
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2022
atoato88
atoato88 reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you to create PR.
It looks almost good but left comment.
Please check those.

pkg/patterns/declarative/pkg/applier/direct.go Outdated
@@ -79,7 +85,7 @@ func (d *DirectApplier) Apply(ctx context.Context, opt ApplierOptions) error {
applyCmd := apply.NewCmdApply(baseName, f, ioStreams)
applyOpts, err := applyFlags.ToOptions(applyCmd, baseName, nil)
if err != nil {
return fmt.Errorf("error getting apply options: %w", err)
return utilerrors.NewAggregate(append(errs, fmt.Errorf("error from SetNamespace: %w", err)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is message of error from SetNamespace correct?

pkg/patterns/declarative/pkg/applier/direct.go Outdated
@@ -106,7 +112,8 @@ func (d *DirectApplier) Apply(ctx context.Context, opt ApplierOptions) error {
IOStreams: ioStreams,
}

return applyOpts.Run()
err = applyOpts.Run()
return utilerrors.NewAggregate(append(errs, fmt.Errorf("error from SetNamespace: %w", err)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ho, I just corrected it.

@atoato88
Copy link
Contributor

atoato88 commented Jun 8, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2022
@xuzhenglun
Copy link
Contributor Author

@atoato88 Is anything else I need to do?

@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@atoato88
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 87eabcb into kubernetes-sigs:master Jun 27, 2022
@jcanseco jcanseco mentioned this pull request Jul 6, 2022
Merged
@xuzhenglun xuzhenglun mentioned this pull request Dec 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

@johnsonj johnsonj Awaiting requested review from johnsonj

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@atoato88 atoato88

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuzhenglun @k8s-ci-robot @atoato88