-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to custom private registry logic #200
allow to custom private registry logic #200
Conversation
Hi @xuzhenglun. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ac6f446
to
3f01136
Compare
/ok-to-test |
It looks good for me because it keep compatibility with current method and you can append additional logic for private repository manipuration. |
/assign @justinsb |
I added lgtm to this PR on Jan, and I approve now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atoato88, xuzhenglun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xuzhenglun |
What this PR does / why we need it:
related with #197
for now, It always replaces the registry endpoint with a namespace (
placeholder/ns/image_name
-->private_registry/image_name
). But I want preserve namespace unchanged, (placeholder/ns/image_name
-->private_registry/ns/image_name
). Compare with adding an newImageRegistryTransform
, leaveapplyPrivateRegistryToImage
func customiable is a better way?Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: