Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to custom private registry logic #200

Conversation

xuzhenglun
Copy link
Contributor

What this PR does / why we need it:

related with #197

  1. add the ability to custom private registry logic:
    for now, It always replaces the registry endpoint with a namespace (placeholder/ns/image_name --> private_registry/image_name ). But I want preserve namespace unchanged, (placeholder/ns/image_name --> private_registry/ns/image_name ). Compare with adding an new ImageRegistryTransform, leave applyPrivateRegistryToImage func customiable is a better way?

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2022
@k8s-ci-robot k8s-ci-robot requested review from droot and estroz January 17, 2022 10:13
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 17, 2022
@xuzhenglun xuzhenglun force-pushed the feauture/custom-private-registry branch from ac6f446 to 3f01136 Compare January 17, 2022 11:14
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2022
@atoato88
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2022
@atoato88
Copy link
Contributor

It looks good for me because it keep compatibility with current method and you can append additional logic for private repository manipuration.
I can't imagine that how much needs to change private repository we have, so I think current PR is OK.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2022
@atoato88
Copy link
Contributor

/assign @justinsb
Could you reveiw this?

@xuzhenglun
Copy link
Contributor Author

ping @justinsb

@atoato88 or maybe we can ask someone else to review this? do you know anyone who is available?

@atoato88
Copy link
Contributor

atoato88 commented Mar 8, 2022

I added lgtm to this PR on Jan, and I approve now.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 608508c into kubernetes-sigs:master Mar 8, 2022
@atoato88
Copy link
Contributor

atoato88 commented Mar 8, 2022

@xuzhenglun
This PR have been merged, thank you to create this.
Could you add unit tests related to this PR as other PR(s) if possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants