-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactory updating status mechanism, status func could handle error #199
refactory updating status mechanism, status func could handle error #199
Conversation
Hi @xuzhenglun. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0eaa81c
to
653a928
Compare
653a928
to
2d08a6c
Compare
/ok-to-test |
/test |
@xuzhenglun: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
/assign @justinsb |
@justinsb please take a look when you are convenient. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atoato88, xuzhenglun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
related with #197:
a. allow status
Reconciled
method known iferror
happened, so that user could be able to submit an error to CR status field or launch an Event;b. maybe it's related with If an object transform fails, status is never updated #190
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: