Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactory updating status mechanism, status func could handle error #199

Merged

Conversation

xuzhenglun
Copy link
Contributor

What this PR does / why we need it:

related with #197:

  1. refractory mechanism of updating status:
    a. allow status Reconciled method known if error happened, so that user could be able to submit an error to CR status field or launch an Event;
    b. maybe it's related with If an object transform fails, status is never updated #190

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 17, 2022
@xuzhenglun xuzhenglun changed the title status func could handle error refactory updating status mechanism, status func could handle error Jan 17, 2022
@xuzhenglun xuzhenglun force-pushed the feauture/error-awared-status branch from 0eaa81c to 653a928 Compare January 17, 2022 11:14
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2022
@xuzhenglun xuzhenglun force-pushed the feauture/error-awared-status branch from 653a928 to 2d08a6c Compare January 17, 2022 11:16
@atoato88
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2022
@xuzhenglun
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link
Contributor

@xuzhenglun: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-declarative-test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuzhenglun
Copy link
Contributor Author

/test all

@atoato88
Copy link
Contributor

/lgtm
I think contents of this PR don't have any side effects, so It's OK.
Reconciled function doesn't use error object on 4th args at here and here.
But on other PR, we can use this object to write more information on status, I think.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2022
@atoato88
Copy link
Contributor

/assign @justinsb
Could you review this?

@xuzhenglun
Copy link
Contributor Author

@justinsb please take a look when you are convenient.

@atoato88
Copy link
Contributor

/approve
This is good update for this repository and confirmed that tests past successfully.
I approve this.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 011adb8 into kubernetes-sigs:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants