Merge pull request #213 from xuzhenglun/fix-211

check object scope before fetching
kubernetes-sigs · Apr 5, 2022 · 8d26bce · 8d26bce
2 parents 63888ac + 9c89b9f
commit 8d26bce
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/patterns/declarative/reconciler.go b/pkg/patterns/declarative/reconciler.go
@@ -606,8 +606,11 @@ func GetObjectFromCluster(obj *manifest.Object, r *Reconciler) (*unstructured.Un
 	if err != nil {
 		return nil, fmt.Errorf("unable to get mapping for resource %v: %w", gvk, err)
 	}
-	ns := obj.GetNamespace()
-	name := obj.GetName()
+
+	ns, name := "", obj.GetName()
+	if mapping.Scope.Name() == meta.RESTScopeNameNamespace {
+		ns = obj.GetNamespace()
+	}
 	unstruct, err := r.dynamicClient.Resource(mapping.Resource).Namespace(ns).Get(context.Background(), name, getOptions)
 	if err != nil {
 		return nil, fmt.Errorf("unable to get object: %w", err)