Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

fix BestEffort for overused #417

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

chenyangxueHDU
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2018
@chenyangxueHDU
Copy link
Contributor Author

/assign @k82cn

@TravisBuddy
Copy link

Travis tests have failed

Hey @chenyangxueHDU,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make verify
go build -o _output/bin/deepcopy-gen ./cmd/deepcopy-gen/
_output/bin/deepcopy-gen -i ./pkg/apis/scheduling/v1alpha1/ -O zz_generated.deepcopy
hack/verify-gofmt.sh
diff -u ./test/e2e/e2e.go.orig ./test/e2e/e2e.go
--- ./test/e2e/e2e.go.orig	2018-10-11 13:22:31.547581760 +0000
+++ ./test/e2e/e2e.go	2018-10-11 13:22:31.547581760 +0000
@@ -221,7 +221,7 @@
 		err = waitTasksNotReady(context, job.Name, nn)
 		Expect(err).NotTo(HaveOccurred())
 	})
-	
+
 	It("Schedule BestEffort Job", func() {
 		context := initTestContext()
 		defer cleanupTestContext(context)
diff -u ./test/e2e/util.go.orig ./test/e2e/util.go
--- ./test/e2e/util.go.orig	2018-10-11 13:22:31.555578130 +0000
+++ ./test/e2e/util.go	2018-10-11 13:22:31.555578130 +0000
@@ -721,4 +721,3 @@
 		return taskNum <= readyTaskNum, nil
 	}
 }
-
make: *** [verify] Error 1
TravisBuddy Request Identifier: 7e440da0-cd5a-11e8-9005-69b5ac3c7904

@k82cn
Copy link
Contributor

k82cn commented Oct 12, 2018

run ./hack/update-gofmt.sh to correct build error :)

@TravisBuddy
Copy link

Travis tests have failed

Hey @chenyangxueHDU,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make verify
go build -o _output/bin/deepcopy-gen ./cmd/deepcopy-gen/
_output/bin/deepcopy-gen -i ./pkg/apis/scheduling/v1alpha1/ -O zz_generated.deepcopy
hack/verify-gofmt.sh
diff -u ./test/e2e/e2e.go.orig ./test/e2e/e2e.go
--- ./test/e2e/e2e.go.orig	2018-10-12 04:09:25.303854779 +0000
+++ ./test/e2e/e2e.go	2018-10-12 04:09:25.303854779 +0000
@@ -221,7 +221,7 @@
 		err = waitTasksNotReady(context, job.Name, nn)
 		Expect(err).NotTo(HaveOccurred())
 	})
-	
+
 	It("Schedule BestEffort Job", func() {
 		context := initTestContext()
 		defer cleanupTestContext(context)
make: *** [verify] Error 1
TravisBuddy Request Identifier: 6f530f90-cdd6-11e8-9005-69b5ac3c7904

@k82cn
Copy link
Contributor

k82cn commented Oct 12, 2018

/approve

please combine those commits into one; I'll lgtm when CI is happy.

BTW, please rebase for #419

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenyangxueHDU, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@chenyangxueHDU
Copy link
Contributor Author

/approve

please combine those commits into one; I'll lgtm when CI is happy.

BTW, please rebase for #419

Done :)

@TravisBuddy
Copy link

Travis tests have failed

Hey @chenyangxueHDU,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make verify
go build -o _output/bin/deepcopy-gen ./cmd/deepcopy-gen/
_output/bin/deepcopy-gen -i ./pkg/apis/scheduling/v1alpha1/ -O zz_generated.deepcopy
hack/verify-gofmt.sh
diff -u ./test/e2e/e2e.go.orig ./test/e2e/e2e.go
--- ./test/e2e/e2e.go.orig	2018-10-12 10:10:01.706163839 +0000
+++ ./test/e2e/e2e.go	2018-10-12 10:10:01.706163839 +0000
@@ -221,7 +221,7 @@
 		err = waitTasksNotReady(context, job.Name, nn)
 		Expect(err).NotTo(HaveOccurred())
 	})
-	
+
 	It("Schedule BestEffort Job", func() {
 		context := initTestContext()
 		defer cleanupTestContext(context)
make: *** [verify] Error 1
TravisBuddy Request Identifier: d05ac530-ce08-11e8-b4b8-efdbea9fb873

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018
Copy link
Contributor

@k82cn k82cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c4cda49 into kubernetes-retired:master Oct 12, 2018
k8s-ci-robot added a commit that referenced this pull request Oct 15, 2018
…release-0.2

Automated cherry pick of #419: Imported golang golint. #417: fix BestEffort Job for overused
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants