Initial IPv6 support #636
Initial IPv6 support #636
Conversation
Adds an environment variable (IP_FAMILT) to the script that runs the e2e tests in the CI to allow to choose the kubernetes ip family used in the clusters. By default the variable choose ipv4
This commits adds allows kind to create IPv6 Kubernetes clusters and makes the code ready to implement dual stack support. For simplicity, only one address of each ip family is considered. It adds 2 new options to the v1alpha3 API: ipFamily and serviceSubnet
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/test pull-kind-conformance-parallel-ipv6 |
|
@BenTheElder: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
the last commit fixed the job (still failing, but only because some of the conformance test ipv6 issues that are known and don't appear to be kind specific) |
BenTheElder
requested review from
aojea and
amwat
and removed request for
munnerz
BenTheElder
added
the
lgtm
|
locally tested with single node 😉 |
|
(self lgtm because my additional commit is a trivial fix, and I already approve all of the remaining code :-)) |
|
Omg I'm almost crying with the emotion |
|
nice work, guys. 🎉 |
|
Let's go get a CI job up! |
| @@ -347,3 +363,4 @@ kind, the Kubernetes cluster itself, etc. | |||
| [Kubernetes imagePullPolicy]: https://kubernetes.io/docs/concepts/containers/images/#updating-images | |||
| [Private Registries]: /docs/user/private-registries | |||
| [customize control plane with kubeadm]: https://kubernetes.io/docs/setup/independent/control-plane-flags/ | |||
| [docker enable ipv6]: https://docs.docker.com/config/daemon/ipv6/ | |||
There was a problem hiding this comment.
the instructions on that page don't set fixed-cidr-v6 so the daemon fails to start
There was a problem hiding this comment.
I remember running into this now... shall we send them a PR? 🙃
https://github.com/docker/docker.github.io/edit/master/config/daemon/ipv6.md
There was a problem hiding this comment.
They have it documented here https://docs.docker.com/v17.09/engine/userguide/networking/default_network/ipv6/ , don´t know why they didn´t explain it in that link
|
Should we switch links then?
…On Sat, Jun 22, 2019, 03:10 Antonio Ojea ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In site/content/docs/user/quick-start.md
<#636 (comment)>:
> @@ -347,3 +363,4 @@ kind, the Kubernetes cluster itself, etc.
[Kubernetes imagePullPolicy]: https://kubernetes.io/docs/concepts/containers/images/#updating-images
[Private Registries]: /docs/user/private-registries
[customize control plane with kubeadm]: https://kubernetes.io/docs/setup/independent/control-plane-flags/
+[docker enable ipv6]: https://docs.docker.com/config/daemon/ipv6/
They have it documented here
https://docs.docker.com/v17.09/engine/userguide/networking/default_network/ipv6/
, don´t know why they didn´t explain it in that link
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#636?email_source=notifications&email_token=AAHADKZMFUCEBJ3LRE2AQQTP3X3CFA5CNFSM4H2UPY3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4K5TZQ#discussion_r296441089>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHADKY67KXHHSLVFXIZMQLP3X3CFANCNFSM4H2UPY3A>
.
|
@aojea's PR (#348) is really close, seeing if we can finish it up before 0.4 :-)