Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update local-path-provisioner #3819

Merged
merged 2 commits into from
Dec 13, 2024
Merged

update local-path-provisioner #3819

merged 2 commits into from
Dec 13, 2024

Conversation

BenTheElder
Copy link
Member

with changes from v0.0.24 to v0.30.0 in usptream yaml, document the changes we apply, pickup new image

/hold
need to fix our dependency on scripts/build upstream
#3818 (comment)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea December 12, 2024 21:56
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2024
@BenTheElder
Copy link
Member Author

filed #3820

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
@BenTheElder BenTheElder changed the title [WIP] update local-path-provisioner update local-path-provisioner Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 12, 2024
@BenTheElder
Copy link
Member Author

/retest
(pod scheduling timeouts in prow, tests didn't run)

@BenTheElder
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2024
@BenTheElder
Copy link
Member Author

/hold cancel
updated the RBAC, though admittedly it is copy-pasted from upstream without deep scrutiny.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@BenTheElder
Copy link
Member Author

well ... we definitely broke PVs, seems like the RBAC changes are broken, will look later.

@BenTheElder
Copy link
Member Author

yeah, that'll do it https://github.com/kubernetes-sigs/kind/compare/4dfc5211d5086e91f3b8fa6b71f4859ed0b3eaf3..0dea9ca6a18813ea4417680d8124195efe5ab5be

@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit e7cf729 into kubernetes-sigs:main Dec 13, 2024
30 checks passed
@BenTheElder BenTheElder deleted the new-storage branch December 13, 2024 16:33
@BenTheElder
Copy link
Member Author

ok now I think it's time for a new node image, we've had some time to soak the changes in Kubernetes CI and I'm not seeing new flakes 🤞 and we've collected up the upgrades to latest again ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@stmcginnis stmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @stmcginnis