-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to currently supported fedora #3654
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#3653 is good, but I kind of think it might be good to just make the bigger jump while we're at it. /lgtm |
/override pull-kind-e2e-kubernetes-1-29 pod scheduling timeout in prow is not great but also not relevant to this PR |
@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-kind-e2e-kubernetes-1-29 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change isn't working yet. |
8d1bcb0
to
4b826f7
Compare
Looks like Fedora 39 works. It's still supported but 40 would be more current. It also looks like the downloads are slow and we should switch back to downloading from a mirror. |
Just capturing failure message here for convenience and in case we lose the job logs. Pod "pfpod2" is invalid: [spec.containers[0].resources.requests: Invalid value: "600m": must be less than or equal to cpu limit of 500m, spec.containers[0].resources.requests: Invalid value: "600Gi": must be less than or equal to ephemeral-storage limit of 500Gi, spec.containers[0].resources.requests: Invalid value: "600Mi": must be less than or equal to memory limit of 500Mi] |
So that's a bug in the upstream tests and we should file an issue there, it's defintiely not related to this PR which only affects some of the github actions. |
d0ee6a2
to
0ff901d
Compare
/override pull-kind-e2e-kubernetes-1-26 pull-kind-e2e-kubernetes-1-27 (prow e2e not relevant for this change) |
@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-kind-e2e-kubernetes-1-26, pull-kind-e2e-kubernetes-1-27 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
actions are passing, I lost context and I can't see how to pull up older runs easily on github for comparison, so I'm not sure if the download is faster but it seems sufficiently fast. |
/hold-cancel |
Looking under the Actions tab, I took a look at this and past runs. The current The same jobs with the "e2e-k8s.sh: support --ginkgo.label-filter" PR took between 4:35 and 5:43. So very slightly more time with the newer Fedora, but that image is probably very slightly larger than the older one anyway. That seems reasonable to me. /lgtm |
@BenTheElder: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold cancel |
stop hardcoding exact downloadxref #3653
/hold
TODO: figure out why fedora 40 isn't working