Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pause image to 3.10 #3627

Merged
merged 1 commit into from
Jun 4, 2024
Merged

update pause image to 3.10 #3627

merged 1 commit into from
Jun 4, 2024

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented May 24, 2024

start using registry.k8s.io/pause:3.10

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @bzsuni!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @bzsuni. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2024
@bzsuni
Copy link
Contributor Author

bzsuni commented May 24, 2024

ref kubernetes/kubernetes#125092

neolit123
neolit123 reviewed May 24, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@neolit123
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2024
@stmcginnis
Copy link
Contributor

/lgtm

BenTheElder
BenTheElder reviewed May 24, 2024
View reviewed changes
pkg/cluster/nodeutils/util_test.go Outdated
@@ -77,7 +77,7 @@ func TestParseSnapshotter(t *testing.T) {
max_container_log_line_size = 16384
netns_mounts_under_state_dir = false
restrict_oom_score_adj = false
sandbox_image = "registry.k8s.io/pause:3.7"
sandbox_image = "registry.k8s.io/pause:3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test shouldn't need changing, it's just test data. let's not change it and then it won't match a search and replace for the tag next time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right, I've revert it, thank you

@BenTheElder
Copy link
Member

FWIW we've not been bumping this because all of the changes since ... 3.3? 3.6? have been windows-only and kind nodes do not run on windows.

I am still +1 to update though, pending dropping the unrelated test-data change (it's harmless, but we don't want to keep churning this every time and it's a bad sign if the tests fail when we change the real file)

@bzsuni bzsuni force-pushed the bz/update/pause branch from ed85014 to e5ba72f Compare May 25, 2024 00:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2024
@stmcginnis
Copy link
Contributor

/lgtm

Took a little closer look since it sounds like updating isn't strictly necessary. The last time the Linux pause source was changed was ~4 years ago, and newer updates to the container image have all been for Windows. That said, it looks like something is overlooked if we don't keep this at least somewhat updated. There's a 10K difference in size, so not much harm there.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2024
BenTheElder
BenTheElder reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, bzsuni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit b39bf4d into kubernetes-sigs:main Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@neolit123 neolit123 neolit123 left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@neolit123 neolit123

@stmcginnis stmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzsuni @k8s-ci-robot @neolit123 @stmcginnis @BenTheElder