Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade kindnetd and storage provisioner to latest images #3148

Merged
merged 2 commits into from
Mar 30, 2023
Merged

upgrade kindnetd and storage provisioner to latest images #3148

merged 2 commits into from
Mar 30, 2023

Conversation

BenTheElder
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aojea and neolit123 March 30, 2023 05:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2023
@BenTheElder
Copy link
Member Author

Waiting for e2e results on prow. The other e2es will require a new node image, and before pushing node images I want to get some more signal.

We need to do those soon to get in gear to release with the runc update.

@BenTheElder
Copy link
Member Author

green CI, will bump the node image to roll up all these patches

@BenTheElder BenTheElder merged commit cb80744 into kubernetes-sigs:main Mar 30, 2023
@BenTheElder BenTheElder deleted the new-images branch March 30, 2023 05:56
@BenTheElder
Copy link
Member Author

~/go/src/sigs.k8s.io/kind/hack/release/build/push-node.sh is running for 1.26.3

@BenTheElder
Copy link
Member Author

BenTheElder commented Mar 30, 2023 •
edited
Loading

Ah, I recall now why we aren't pinning the base image by digest:

docker: Cannot overwrite digest sha256:9a6fdcb973d88d816763257c4f800eb597969668d9d02a69276200e499017673.

(because we do two architectures on one host alternately with binfmt_misc, but docker will store it based on the digest)

@BenTheElder
Copy link
Member Author

moby/moby#43188

@BenTheElder
Copy link
Member Author

#3149 and retrying

@BenTheElder
Copy link
Member Author

kindest/node:v1.26.3@sha256:61b92f38dff6ccc29969e7aa154d34e38b89443af1a2c14e6cfbd2df6419c66f is live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenTheElder @k8s-ci-robot