Pass PROXY environment variables to nodes

[pablochacin]

Fixes #270

Pass the environment variables HTTP_PROXY/HTTPS_PROXY from the host environment to the nodes, so that the docker running on the node could download images when running behind a proxy (see issue #136)

Signed-off-by: Pablo Chacin [email protected]

[k8s-ci-robot]

Hi @pablochacin. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alejandrox1]

/lgtm

[neolit123]

thanks for the PR @pablochacin

please change Implements issue #270 to Fixes #270
/priority important-longterm
/kind feature

[BenTheElder]

/ok-to-test

[neolit123]

thanks for the update @pablochacin
please squash the commits. this looks good, unless @BenTheElder has comments?

[pablochacin]

thanks for the update @pablochacin
please squash the commits. this looks good, unless @BenTheElder has comments?

Done

[tao12345666333]

lgtm

[BenTheElder]

[I think netlify fails because it doesn't merge the branch into master before building, so this PR branch doesn't contain the netlify configs...]

[BenTheElder]

/lgtm
/approve
thank you!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, pablochacin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

[manual merge due to bogus netlify failures]

[unautre]

Hello,
I am in a similar situation, with a corporate HTTP proxy for outside traffic. After re-installing kind to the latest version (after that merge), it works better.
There is still a problem though, in that kubernetes tries to access cluster-local URLs (172.17.0.2 in my case) through the proxy. Adding those URLs to the NO_PROXY helps kind create the cluster to completion.
Would it be feasible to automatically add local URLs to the NO_PROXY variable ?

Same problem a bit later, the cluster is started, but looking at the logs (kind export logs) it says repeatedly that it's trying to pull a docker image, and failing ; I guess the docker service (inside the container) is not configured to use the proxy.

Edit: after applying the proxy setting to the docker in the kind-control-plane container, the cluster is ready !
Looking at the patch to pass the proxy variables, I guess one could just mount a file in /etc/systemd/system/docker.service.d/http-proxy.conf containing the proxy configuration.

[BenTheElder]

Would it be feasible to automatically add local URLs to the NO_PROXY variable ?

Yeah we could add the clusters IPs to this, it would take a bit of work to compute these.

It also looks like instead users can set https://docs.docker.com/network/proxy/#configure-the-docker-client on the host side before kind creates any clusters.