Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bad entrypoint bash #2320

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

BenTheElder
Copy link
Member

fixes #2313

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021
@aojea
Copy link
Contributor

aojea commented Jun 22, 2021

/lgtm

What is the deal with cut Vs awk?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9fe9644 into kubernetes-sigs:main Jun 22, 2021
@BenTheElder
Copy link
Member Author

cut takes a specific delimeter
awk with print like that is reading the args and selecting the nth arg.
if your input is not just say space delimited, but perhaps varying whitespace, they are not equivilant.

I didn't look too deeply at what happened yet, I just tested reverting the entrypoint because it was the smallest and most trivial thing to test of the two suspect changes. Then I looked at the diff and it dawned on me that they are not the same for all inputs so 🙃

@BenTheElder BenTheElder deleted the revert-bad-bash branch June 22, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting control-plane error with kindest/node:v1.21.1
3 participants