-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix podman getSubnets() #2257
Fix podman getSubnets() #2257
Conversation
/assign @BenTheElder @amwat |
Co-authored-by: Florian BEZANNIER
@AkihiroSuda: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c3b3e10
to
a89d447
Compare
what's the context? did the previous one ever work? did podman change something? |
that is stuck #2199
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I know I know ... too many things sorry |
Fix podman getSubnets()
Since we moved to custom networks, it has to get the information from the kind network
It also carries the fix in #2199 that got stuck on CLA signing