Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman getSubnets() #2257

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

aojea
Copy link
Contributor

@aojea aojea commented May 18, 2021

Fix podman getSubnets()

Since we moved to custom networks, it has to get the information from the kind network
It also carries the fix in #2199 that got stuck on CLA signing

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2021
@k8s-ci-robot k8s-ci-robot requested review from amwat and BenTheElder May 18, 2021 07:51
@k8s-ci-robot k8s-ci-robot added area/provider/podman Issues or PRs related to podman approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2021
@aojea
Copy link
Contributor Author

aojea commented May 18, 2021

/assign @BenTheElder @amwat

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

@AkihiroSuda: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea aojea force-pushed the podmanfixes branch 2 times, most recently from c3b3e10 to a89d447 Compare May 18, 2021 08:02
@aojea aojea changed the title Several Podman fixes Fix podman getSubnets() May 18, 2021
@BenTheElder
Copy link
Member

what's the context? did the previous one ever work? did podman change something?

@aojea
Copy link
Contributor Author

aojea commented May 18, 2021

what's the context? did the previous one ever work? did podman change something?

that is stuck #2199
and when we moved to custom networks I forget to pass the kind network

error unrelated
E: Failed to fetch https://packages.microsoft.com/ubuntu/20.04/prod/dists/focal/main/binary-amd64/Packages.bz2 File has unexpected size (73402 != 73160). Mirror sync in progress? [IP: 40.74.238.15 443]
Hashes of expected file:
- Filesize:73160 [weak]

@BenTheElder
Copy link
Member

/lgtm
/approve
I still think json should be high on the list, but /shrug

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c81569a into kubernetes-sigs:main May 18, 2021
@aojea
Copy link
Contributor Author

aojea commented May 18, 2021

I still think json should be high on the list, but /shrug

I know I know ... too many things sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/podman Issues or PRs related to podman cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants