-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
potential fix for white space in source path #2215
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @jason-kane! |
Hi @jason-kane. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jason-kane you have to sign the CLA |
/lgtm Thanks for fixing this! nit: can you fixup the commit message to not reference the issue number? (https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#do-not-use-github-keywords-or-mentions-within-your-commit-message) We can edit the PR description to add that instead. |
done. |
I signed it |
/check-cla 👍 so, there are actually 3 different things here:
3 is the only problematic one really, as described in the contributor guide. Technically, the current commit description isn't invalid (we already add blocking labels if it were) but good to fix nonetheless. |
c7f0b23
to
0905dd7
Compare
Thank you. I believe I've addressed the remaining two items. The description now references the issue and the commit message does not. |
/check-cla |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, jason-kane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
/retest |
Unrelated failures /override pull-kind-e2e-kubernetes-1-20 |
@amwat: Overrode contexts on behalf of amwat: pull-kind-e2e-kubernetes-1-20 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There may be similar issues elsewhere, this is enough to get
make build
working. Issue #2214