Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror docker images #2105

Closed
wants to merge 1 commit into from
Closed

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Mar 4, 2021

Kind is publishing the official in dockerhub, however, since
the docker decision to rate limit the images, this causes issues
with CIs.

Switching completely the images is complicated, and can be very
disruptive.

Meanwhile we don't have a final decision we can mirror the images
to different public registries.

Fixes: #1895

Kind is publishing the official in dockerhub, however, since
the docker decision to rate limit the images, this causes issues
with CIs.

Switching completely the images is complicated, and can be very
disruptive.

Meanwhile we don't have a final decision we can mirror the images
to different public registries.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from amwat and neolit123 March 4, 2021 09:56
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2021
@aojea
Copy link
Contributor Author

aojea commented Mar 4, 2021

/hold
/assign @BenTheElder
Open for discussion, this still needs to handle the authentication

  • I was thinking in using a dns domain to hide the registries, so we can geodistribute the requests and we no longer depend on the registry provider.
  • Is this the right repo or do we want to use github.com/kind-ci as we do with the containerd nigthly builds
  • ....

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2021
on:
schedule:
- cron: '0 0 * * *'
release:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this runs when a release is created

steps:
- name: Mirror docker images to Github Registry
run: |
skopeo sync --src docker --dest docker docker.io/kindest/node ghcr.io/kind-ci
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar with the feature but if it handles the sync ala rsync that seems exactly what we need

@k8s-ci-robot
Copy link
Contributor

@aojea: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kind-e2e-kubernetes 85878a6 link /test pull-kind-e2e-kubernetes
pull-kind-e2e-kubernetes-1-20 85878a6 link /test pull-kind-e2e-kubernetes-1-20

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333
Copy link
Member

The authentication information can be completed through the configuration of --dest-authfile and --src-authfile combined with GitHub Action encrypted-secrets.

Docker Inc. provides support for open source projects, we can consider using it. https://www.docker.com/community/open-source/application

steps:
- name: Mirror docker images to Github Registry
run: |
skopeo sync --src docker --dest docker docker.io/kindest/node ghcr.io/kind-ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End users will want this mirrored image as well 👍, so maybe -ci suffix can be omitted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind-ci is a github org we own.
Why are we not publishing to this repo?

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm NACK on mirroring to random registries here without deciding on the solution over in the issue.

Any mirroring we run from here is "official" and should be decided and supported. Also because dockerd has poor support for mirrors we should really just pick 1-2 registries to use going forward (maybe k8s official GCR and something else for china, unless we can pick one alternative for both), and mirroring solutions should be done in discussion with wg-k8s-infra.

steps:
- name: Mirror docker images to Github Registry
run: |
skopeo sync --src docker --dest docker docker.io/kindest/node ghcr.io/kind-ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind-ci is a github org we own.
Why are we not publishing to this repo?


- name: Mirror docker images to quay.io
run: |
skopeo sync --src docker --dest docker docker.io/kindest/node quay.io/kind
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who owns this registry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made up the names, the pr is to discuss if this make sense.
If affirmative fill the gaps with whatever we decide

@BenTheElder
Copy link
Member

[thanks for the PR, let's continue discussion elsewhere, closing to minimize issues from #2120 / thundering CI on open PRs with ok-to-test]

[also received contact from docker today about kindest, need to follow up with them]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dockerhub kindest/node to a non rate limited registry
6 participants