-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for Cluster Name via Yaml Configuration #2103
Add Documentation for Cluster Name via Yaml Configuration #2103
Conversation
Welcome @jsievenpiper! |
Hi @jsievenpiper. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @amwat Hope I'm doing this correctly 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
/approve
minor nits
|
||
This name will be used unless you invoke `kind create cluster` with the `--name` | ||
option as well (for example `kind create cluster --config=config.yml --name other`), | ||
in which case `other` will be used since CLI args take precedence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is generally true for every parameter. i.e. CLI flags will overwrite whatever is specified in the config file.
Since this page specifically deals with the config, I think just the config example should suffice here in this subsection.
Even better if we can move this note as a general note at the top somewhere :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for a general note and also the CLI usage documenting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amwat @BenTheElder thanks for the feedback! I pulled that CLI precedence note up and trimmed down the name
section specifically. Good call out!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, jsievenpiper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest |
@jsievenpiper: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
👋🏾 I love this project -- it's been exactly what I needed for a recent project of my own.
I saw that PRs were welcome for some undocumented config file options, so thought I'd lend a hand!