Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try using preinstalled podman #2071

Merged
merged 1 commit into from
Feb 13, 2021
Merged

try using preinstalled podman #2071

merged 1 commit into from
Feb 13, 2021

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Feb 13, 2021 •
edited
Loading

/hold
xref: #2070

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2021
@BenTheElder
Copy link
Member Author

BenTheElder commented Feb 13, 2021 •
edited
Loading

looks like we get 2.2.1 currently, though note:

Ubuntu-latest workflows will use Ubuntu-20.04 soon. For more details, see actions/runner-images#1816

@BenTheElder
Copy link
Member Author

/hold cancel
the current approach fails, this works and the jobs pass using podman.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kind-conformance-parallel-1-17 26d72fd link /test pull-kind-conformance-parallel-1-17

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member Author

log export flakes and prow flakes, but this works, and unblocks having CI again.

@BenTheElder BenTheElder merged commit 1ebe6b0 into kubernetes-sigs:master Feb 13, 2021
@BenTheElder BenTheElder deleted the podman-install-plz branch February 13, 2021 07:29
@BenTheElder BenTheElder mentioned this pull request Feb 13, 2021
Closed
@aojea
Copy link
Contributor

aojea commented Feb 13, 2021

honestly, didn't know podman came preinstalled

aojea
aojea reviewed Feb 13, 2021
View reviewed changes
.github/workflows/podman.yml
curl -L https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/${PODMAN_VERSION}/xUbuntu_${VERSION_ID}/Release.key | sudo apt-key add -
sudo apt-get update -qq
sudo apt-get -qq -y install podman
podman version
# Install network
sudo mkdir -p /etc/cni/net.d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this too?

@aojea aojea mentioned this pull request Feb 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @aojea