-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub actions docker #1980
Add GitHub actions docker #1980
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://github.com/kubernetes-sigs/kind/runs/1562072695?check_suite_focus=true looks like it still fails on |
local current_cgroup | ||
current_cgroup=$(grep systemd /proc/self/cgroup | cut -d: -f3) | ||
local cgroup_subsystems | ||
cgroup_subsystems=$(findmnt -lun -o source,target -t cgroup | grep "${current_cgroup}" | awk '{print $2}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is failing because this path is missing in github actions
Dec 16 08:12:51 kind-control-plane kubelet[3263]: I1216 08:12:51.213645 3263 cgroup_manager_linux.go:294] The Cgroup [kubelet] has some missing paths: [/sys/fs/cgroup/systemd/kubelet/kubelet]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubelet error says is missing that path 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are the paths that the kubelet is building
Dec 16 09:02:53 kind-control-plane kubelet[22444]: I1216 09:02:53.236466 22444 cgroup_manager_linux.go:269] DEBUG Cgroups [kubelet] paths map[blkio:/sys/fs/cgroup/blkio/kubelet cpu:/sys/fs/cgroup/
cpu,cpuacct/kubelet cpuacct:/sys/fs/cgroup/cpu,cpuacct/kubelet cpuset:/sys/fs/cgroup/cpuset/kubelet devices:/sys/fs/cgroup/devices/kubelet freezer:/sys/fs/cgroup/freezer/kubelet hugetlb:/sys/fs/cgro
up/hugetlb/kubelet memory:/sys/fs/cgroup/memory/kubelet net_cls:/sys/fs/cgroup/net_cls,net_prio/kubelet net_prio:/sys/fs/cgroup/net_cls,net_prio/kubelet perf_event:/sys/fs/cgroup/perf_event/kubelet
pids:/sys/fs/cgroup/pids/kubelet rdma:/sys/fs/cgroup/rdma/kubelet systemd:/sys/fs/cgroup/systemd/kubelet/kubelet]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is building the systemd path incorrectly the kubelet?
systemd:/sys/fs/cgroup/systemd/kubelet/kubelet]
fixed by #1995 |
/hold
superset of #1979
adds 451d401
more focused on getting #1979, haven't really reviewed this config yet, will look at it more later.