Add CI for docker in Github Actions #1965

aojea · 2020-12-07T20:16:05Z

It also fixes a bug where the images failed to run after they were created locally

When we added Support configuring a cgroup root for kubelet #1747 , we checked for podman or docker to remount the cgroups. However, docker in Github doesn't show docker in its cgroup path, causing that the script didn't remounted the cgroups subsystems under /kubelet, hence the kubelet, that is configured to use cgroup-root: /kubelet fails to start because there is nothing in that path.

grep /sys/fs/cgroup /proc/self/mountinfo | grep docker
root@kind-control-plane:/usr/local/bin#

Fixes: #1969

k8s-ci-robot · 2020-12-07T20:16:16Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
To complete the pull request process, please assign bentheelder after the PR has been reviewed.
You can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aojea · 2020-12-07T20:16:26Z

/assign @BenTheElder

aojea · 2020-12-07T20:17:31Z

.github/workflows/docker.yml

+      IP_FAMILY: ${{ matrix.ipFamily }}
+    steps:
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v2


@BenTheElder FYI actions/checkout#27 (comment)

BenTheElder · 2020-12-07T21:41:10Z

interesting that it does not break here 🤔

aojea · 2020-12-07T22:11:16Z

for reference, it fails here for the cgroup you can get the logs from here https://github.com/aojea/ovn-kubernetes/runs/1512853588?check_suite_focus=true with following error

Dec 07 19:16:44 ovn-control-plane kubelet[994]: F1207 19:16:44.170173 994 server.go:269] failed to run Kubelet: invalid configuration: cgroup-root ["kubelet"] doesn't exist
Dec 07 19:16:44 ovn-control-plane kubelet[994]: goroutine 1 [running]:

aojea · 2020-12-10T10:08:11Z

we have a reproducer and a job to test that we don´t break last stable version
https://github.com/kubernetes-sigs/kind/pull/1965/checks?check_run_id=1529704560

BenTheElder · 2020-12-12T00:03:58Z

/retest

lotharschulz · 2020-12-15T14:43:45Z

.github/workflows/docker.yml

+        continue-on-error: true
+
+      - name: Export logs
+        if: always()


Suggested change

if: always()

if: ${{ always() }}

The double curly braces syntax is used in line 56 as well and is in line with the documentation. If this suggestion is accepted the same change should apply to line 88.

aojea · 2020-12-15T17:14:12Z

pkg/build/nodeimage/defaults.go

@@ -20,7 +20,7 @@ package nodeimage
 const DefaultImage = "kindest/node:latest"

 // DefaultBaseImage is the default base image used
-const DefaultBaseImage = "kindest/base:v20201130-23777eca"
+const DefaultBaseImage = "kindest/base:v20201204-49cad832"


ping @BenTheElder , however, this doesn't solve the problem

where did you pull that from? note: random images in this repo are not supported.
I dont think we missed any bumps merging.

pulled from here https://hub.docker.com/r/kindest/base/tags?page=1&ordering=last_updated , it says updated 11 days ago

aojea · 2020-12-15T23:17:31Z

/close
#1979

k8s-ci-robot · 2020-12-15T23:17:41Z

@aojea: Closed this PR.

In response to this:

/close
#1979

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BenTheElder · 2020-12-16T00:38:17Z

.github/workflows/compatibility.yml

@@ -0,0 +1,86 @@
+name: Compatibility


this we don't guarantee and was a red-herring

BenTheElder · 2020-12-16T00:38:32Z

.github/workflows/docker.yml

@@ -0,0 +1,95 @@
+name: Docker


a variant of this we should probably keep somewhere.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2020

k8s-ci-robot requested review from munnerz and neolit123 December 7, 2020 20:16

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2020

k8s-ci-robot assigned BenTheElder Dec 7, 2020

aojea commented Dec 7, 2020

View reviewed changes

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2020

aojea force-pushed the dockerci branch from c13746a to 6e4e710 Compare December 10, 2020 09:45

aojea mentioned this pull request Dec 10, 2020

Kubelet: invalid configuration: cgroup-root ["kubelet"] doesn't exist #1969

Closed

aojea force-pushed the dockerci branch 7 times, most recently from c87154a to faf7cd1 Compare December 15, 2020 14:21

lotharschulz reviewed Dec 15, 2020

View reviewed changes

aojea force-pushed the dockerci branch from faf7cd1 to dba50e6 Compare December 15, 2020 14:58

aojea commented Dec 15, 2020

View reviewed changes

Antonio Ojea added 3 commits December 15, 2020 23:41

Add CI for docker in Github Actions

451d401

ci for images compatibility

23570b9

bump base image

e5285fe

aojea force-pushed the dockerci branch from 61cc4a7 to e8ed661 Compare December 15, 2020 22:42

aojea force-pushed the dockerci branch from e8ed661 to d5257a7 Compare December 15, 2020 22:48

always mount kubelet root cgroup

fa34b4c

aojea force-pushed the dockerci branch from d5257a7 to fa34b4c Compare December 15, 2020 22:53

k8s-ci-robot closed this Dec 15, 2020

BenTheElder reviewed Dec 16, 2020

View reviewed changes

.github/workflows/compatibility.yml

@@ -0,0 +1,86 @@

name: Compatibility

Copy link

Member

BenTheElder Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this we don't guarantee and was a red-herring

BenTheElder reviewed Dec 16, 2020

View reviewed changes

.github/workflows/docker.yml

@@ -0,0 +1,95 @@

name: Docker

Copy link

Member

BenTheElder Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a variant of this we should probably keep somewhere.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI for docker in Github Actions #1965

Add CI for docker in Github Actions #1965

aojea commented Dec 7, 2020 •

edited

Loading

k8s-ci-robot commented Dec 7, 2020

aojea commented Dec 7, 2020

aojea Dec 7, 2020

BenTheElder commented Dec 7, 2020

aojea commented Dec 7, 2020

aojea commented Dec 10, 2020 •

edited

Loading

BenTheElder commented Dec 12, 2020

lotharschulz Dec 15, 2020

lotharschulz Dec 15, 2020 •

edited

Loading

aojea Dec 15, 2020

aojea Dec 15, 2020

BenTheElder Dec 15, 2020

aojea Dec 15, 2020

aojea commented Dec 15, 2020

k8s-ci-robot commented Dec 15, 2020

BenTheElder Dec 16, 2020

BenTheElder Dec 16, 2020

Add CI for docker in Github Actions #1965

Add CI for docker in Github Actions #1965

Conversation

aojea commented Dec 7, 2020 • edited Loading

k8s-ci-robot commented Dec 7, 2020

aojea commented Dec 7, 2020

Choose a reason for hiding this comment

BenTheElder commented Dec 7, 2020

aojea commented Dec 7, 2020

aojea commented Dec 10, 2020 • edited Loading

BenTheElder commented Dec 12, 2020

Choose a reason for hiding this comment

lotharschulz Dec 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aojea commented Dec 15, 2020

k8s-ci-robot commented Dec 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aojea commented Dec 7, 2020 •

edited

Loading

aojea commented Dec 10, 2020 •

edited

Loading

lotharschulz Dec 15, 2020 •

edited

Loading