clarify error getting ipv6 address on node #1960
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
| @@ -166,7 +168,7 @@ func (a *Action) Execute(ctx *actions.ActionContext) error { | |||
|
|
|||
| // getKubeadmConfig generates the kubeadm config contents for the cluster | |||
| // by running data through the template and applying patches as needed. | |||
| func getKubeadmConfig(cfg *config.Cluster, data kubeadm.ConfigData, node nodes.Node) (path string, err error) { | |||
| func getKubeadmConfig(cfg *config.Cluster, data kubeadm.ConfigData, node nodes.Node, provider string) (path string, err error) { | |||
There was a problem hiding this comment.
I doubted between passing the whole context or adding a new argument, since it is only a string and doesn't look like this is going to grow much, I pick the later
There was a problem hiding this comment.
I still need to take a sledgehammer to this code anyhow :-)
this is a reasonable approach for now 👍
BenTheElder
added
approved
Improve the validation when getting an IPv6 address from a node, and clarify the error message, specifying the container provider that is failing