-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do the same kind of cgroup fix also for podman #1639
Conversation
The mounts that were fixed for docker, also needs fixing for podman (which uses the name "libpod_parent" for them)
Welcome @afbjorklund! |
Hi @afbjorklund. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks for the PR! |
@afbjorklund: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
failure is a bug in the CI which has a patch set to roll out monday + some timeouts due to resource contention issues in CI. ignoring. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bypassing CI issues. |
The mounts that were fixed for docker, also needs fixing
for podman (which uses the name "libpod_parent" for them)
This is needed for minikube, that supports podman as well
Basically it is the same as docker, with 6 characters changed
See kubernetes/minikube#8033