Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow loadbalancer to restart gracefully #1564

Merged
merged 1 commit into from
May 6, 2020

Conversation

aojea
Copy link
Contributor

@aojea aojea commented May 5, 2020

  • Use hostnames instead of IP addresses for the backends
  • Use the wll known dns resolver for haproxy
  • Allow haproxy to keep working despite the backends are not resolvable

Fixes #1562

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2020
@k8s-ci-robot k8s-ci-robot requested review from amwat and BenTheElder May 5, 2020 10:57
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 5, 2020
@aojea
Copy link
Contributor Author

aojea commented May 5, 2020

/assign @BenTheElder

@BenTheElder
Copy link
Member

podman? :+)

@aojea
Copy link
Contributor Author

aojea commented May 5, 2020

podman? :+)

I will get my hands in podman soon ;)

is HA something expected to work in podman now?

@BenTheElder
Copy link
Member

Yes, AFAIK.

There's no reason this shouldn't be possible to do portably.

@@ -45,6 +48,8 @@ defaults
timeout connect 5000
timeout client 50000
timeout server 50000
# allow to boot despite dns don't resolve backends
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future we might want to clarify this comment a bit, something like "don't exit when we can't yet resolve backends"

@BenTheElder
Copy link
Member

/lgtm
/approve
podman cleanup in a follow-up is going to be messy :/
it's really obnoxious that we need to pass all this resolver info, why can't it respect resolv.conf? :/

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9ba9cca into kubernetes-sigs:master May 6, 2020
@aojea
Copy link
Contributor Author

aojea commented May 6, 2020

/lgtm
/approve
podman cleanup in a follow-up is going to be messy :/
it's really obnoxious that we need to pass all this resolver info, why can't it respect resolv.conf? :/

ahh, it can, I just added it to enforce using the dns resolver ...
Let me open an issue so I don't forget to come back to it

@aojea aojea deleted the restartlb branch August 9, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HA proxy is not restarted after host restart
3 participants