Support BTRFS and ZFS docker storage #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
neolit123
reviewed
Apr 6, 2020
BenTheElder
reviewed
Apr 6, 2020
| @@ -164,9 +164,32 @@ func commonArgs(cluster string, cfg *config.Cluster) ([]string, error) { | |||
| if usernsRemap() { | |||
| args = append(args, "--userns=host") | |||
| } | |||
|
|
|||
| // handle Docker on Btrfs or ZFS | |||
| dockerStorage, err := getDockerStorage() | |||
There was a problem hiding this comment.
in the future this should be refactored to get all the docker info we want, we should avoid unnecessarily making extra info calls.
BenTheElder
reviewed
Apr 6, 2020
|
/approve |
k8s-ci-robot
added
the
approved
It seems that mounting /dev/mapper from the host to the kind nodes remove the limitation on Docker of using BTRFS or ZFS https://kind.sigs.k8s.io/docs/user/known-issues/#docker-on-btrfs-or-zfs
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
BenTheElder
reviewed
Apr 7, 2020
| storage := "" | ||
| cmd := exec.Command("docker", "info", "-f", "{{.Driver}}") | ||
| lines, err := exec.CombinedOutputLines(cmd) | ||
| if err != nil { |
There was a problem hiding this comment.
i'm not sure if this is the right approach here, but at least it's consistent.
this needs to get refactored anyhow, kind bootstrap has a lot of unnecessary complications I want to clobber after #148
There was a problem hiding this comment.
is consistent and is less disruptive, in case of failure it works as usual
🤷♂
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cannonpalms
added a commit
to cannonpalms/cluster-api
that referenced
this pull request
Mar 26, 2023
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps kubernetes-sigs#8317
cannonpalms
added a commit
to cannonpalms/cluster-api
that referenced
this pull request
Nov 14, 2023
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps kubernetes-sigs#8317
cannonpalms
added a commit
to cannonpalms/cluster-api
that referenced
this pull request
Jan 16, 2024
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps kubernetes-sigs#8317 chore: PR feedback Removes the now-unused function mountDevMapper(...) chore: fix ci lint fix: restore missing storage consts
cannonpalms
added a commit
to cannonpalms/cluster-api
that referenced
this pull request
Feb 1, 2024
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps kubernetes-sigs#8317 chore: PR feedback Removes the now-unused function mountDevMapper(...) chore: fix ci lint fix: restore missing storage consts
cannonpalms
added a commit
to cannonpalms/cluster-api
that referenced
this pull request
Feb 1, 2024
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps kubernetes-sigs#8317 chore: PR feedback Removes the now-unused function mountDevMapper(...) chore: fix ci lint fix: restore missing storage consts chore: fix bad rebase mountDevMapper() is unused
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps kubernetes-sigs#8317 chore: PR feedback Removes the now-unused function mountDevMapper(...) chore: fix ci lint fix: restore missing storage consts chore: fix bad rebase mountDevMapper() is unused
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
Support for btrfs/zfs was upstreamed to kind in kubernetes-sigs/kind#1464, removing the need for us to hack support in ourselves. Helps kubernetes-sigs#8317 chore: PR feedback Removes the now-unused function mountDevMapper(...) chore: fix ci lint fix: restore missing storage consts chore: fix bad rebase mountDevMapper() is unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that mounting /dev/mapper from the host to the kind
nodes remove the limitation on Docker of using BTRFS or ZFS
https://kind.sigs.k8s.io/docs/user/known-issues/#docker-on-btrfs-or-zfs
Fixes: #1416