Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kind build base-image #1376

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

BenTheElder
Copy link
Member

the base image should be built with the makefile from a checkout, this subcommand is lingering tech debt and out of sync.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 29, 2020
@tao12345666333
Copy link
Member

/lgtm

Some documents need to be updated afterwards.

(MoeLove) ➜  kind git:(master) ✗ rg 'kind build base-image'
images/base/README.md
6:The image can be built with `kind build base-image`.

site/content/docs/design/node-image.md
19:and they can be built with `kind build base-image` and `kind build node-image` respectively.

site/content/docs/user/quick-start.md
239:kind build base-image
252:kind build base-image --image base:v0.1.0

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit a5aac36 into kubernetes-sigs:master Feb 29, 2020
tao12345666333 added a commit to tao12345666333/kind that referenced this pull request Feb 29, 2020
@BenTheElder BenTheElder deleted the no-build-base branch February 29, 2020 19:38
@BenTheElder
Copy link
Member Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants