Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental provider override env #1296

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

BenTheElder
Copy link
Member

... and now that we actually compile this code, drop unnecessary dep

/cc @amwat

@k8s-ci-robot k8s-ci-robot requested a review from amwat January 29, 2020 22:15
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2020
@BenTheElder
Copy link
Member Author

follow up to #1293

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@BenTheElder
Copy link
Member Author

prow flake
/retest

@amwat
Copy link
Contributor

amwat commented Jan 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@BenTheElder
Copy link
Member Author

hung prowjob xref: #1298

@BenTheElder BenTheElder merged commit 3f3b305 into kubernetes-sigs:master Jan 30, 2020
@BenTheElder BenTheElder deleted the provider-override branch January 30, 2020 00:04
@BenTheElder
Copy link
Member Author

xref: #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants