Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeconfig documentation #1032

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Oct 31, 2019

follow up on #1029

@k8s-ci-robot k8s-ci-robot requested review from amwat and munnerz October 31, 2019 07:11
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
To complete the pull request process, please assign bentheelder
You can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2019
@aojea aojea mentioned this pull request Oct 31, 2019
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly updating the docs!

site/content/docs/user/quick-start.md Outdated Show resolved Hide resolved
site/content/docs/user/quick-start.md Outdated Show resolved Hide resolved
site/content/docs/user/quick-start.md Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member

BenTheElder commented Oct 31, 2019 via email

@aojea
Copy link
Contributor Author

aojea commented Oct 31, 2019

/hold

NOTE: Don't forget to merge before the release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2019
@BenTheElder BenTheElder merged commit 9b7097e into kubernetes-sigs:master Nov 18, 2019
@BenTheElder
Copy link
Member

merged just after the release! 😅

@aojea aojea deleted the kubeconfig branch August 9, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants