Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1alpha5 API design #2023

Open
BenTheElder opened this issue Jan 22, 2021 · 6 comments
Open

v1alpha5 API design #2023

BenTheElder opened this issue Jan 22, 2021 · 6 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@BenTheElder
Copy link
Member

We should add a new API revision in order to make some improvements, here is what I have in mind:

  1. dual-stack network configuration (a good reason for people to upgrade 🙃 ) Add dual stack support #692 DualStack UX #1275
  2. extraMounts should only resolve paths to absolute if they contain a path separator support docker volumes in extra mounts #1966
  3. kubeadmConfigPatches => componentConfigPatches + enhance Kubernetes component config patching
    • Doing this allows us to support future component config patching without more fields
    • This is more consistent with the intention of the existing field now that we're not using only kubeadm component config
    • We should rewrite the bootstrapping process to use modern kubeadm (phases) and patch per-node kubelet config on-disk
    • We should reject per-node kube-proxy config (only allow this on the cluster-wide config patches)
    • We should reject per-node kubeadm init config if it's not on the correct node (first control-plane), or just on all nodes
    • We should consider rejecting kubeadm join config if it's on the first control-plane node
  4. Support node labeling in config Support node labels within config files #1574 / added: support for adding labels from the config file itself #1926

I'm aware of other possible improvements not named above, but I think this is already a lot to work on for the next release, besides changes that aren't API specific, listing them anyhow to start thinking about some more:

@BenTheElder BenTheElder added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 22, 2021
@BenTheElder BenTheElder added this to the v0.11.0 milestone Jan 22, 2021
@BenTheElder
Copy link
Member Author

BenTheElder commented Jan 22, 2021

We should also start labeling when support for a field was introduced in https://kind.sigs.k8s.io/docs/user/configuration/ and ensure all fields are in that doc.

EDIT: this is now #2026

@neolit123
Copy link
Member

kubeadmConfigPatches => componentConfigPatches + enhance Kubernetes component config patching

i like this.

@aojea
Copy link
Contributor

aojea commented Mar 19, 2021

For dualstack we don't need anything new, just a new field for networking.IPFamily

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2021
@aojea
Copy link
Contributor

aojea commented Jun 17, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2021
@BenTheElder
Copy link
Member Author

1 & 4 shipped as additions to v1alpha4

2 pretty much has to be a new one I think, because it's a breaking behavior change in the field.

3 is pretty high effort and I'm not sure we're finding the time. I think it should still happen, but I'm not sure when ...

@BenTheElder BenTheElder removed this from the v0.11.0 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants