-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON6902 patches should allow matching on group when version is not specified #1332
Comments
Hi @BenTheElder, I have an idea.
If the version field is empty, then we could get the |
This is only for Kubeadm patch. For others, e.g. containerd patch, I have to dig more, or maybe this approach could also work |
We should not take this approach, because we also need to patch other component configs (kube-proxy, kubelet...) We should fix how the match considers the group / version to be matching, the merge patches already support this correctly. |
"kubeadm config" is a bit of a misnomer and should probably get renamed, those patches patch the data that is supplied to kubeadm currently, which is more than just kubeadm's config object(s). |
Your are right. I just focused on |
re: renaming #2023 |
What would you like to be added:
the internal patch runtime should handle group / version matching so that GK can be specified without full GVK (Group, Version, Kind).
basically we want to allow not specfiying V (version) since versions are often largely the same but group and kind key totally different objects and we probably don't want patches applied to all objects.
Why is this needed:
To avoid surprising behavior when version is left unspecified in JSON6902 patches
/assign
The text was updated successfully, but these errors were encountered: