-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multiple CRI within the nodes #153
Comments
In my opinion, we don't need to install all of these in the base image. We can have multiple types of base image by image tag. And choose one by a flag called |
If we have a CRI flag it would have to just be in the base image, which might make There are some trade-offs with how many images we need to build and maintain, UX, image size, etc. |
Yes. If they are all installed to the base image, the image will become bigger. I am very happy to participate in this. |
@mrunalp ptal as well |
/lifecycle frozen |
CRI-O is feasible if someone can figure out how to do the image loading step reasonably. /remove-lifecycle frozen |
[changed my mind on frozen for this issue... but moving to backlog as it's not really clear that varying CRIs on the nodes matters for cases kind is suited to, and this will introduce additional complexity] |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
we've gotten rid of the lifecycling entirely in this repo for now, but, I still don't think this is the right thing for us to focus on. it does not enable more people to run kind or help people test their apps (portable k8s apps should NOT be aware of which CRI) and for testing kubernetes this is more appropriately done in the node_e2e testing (which involves individual VMs doing integration tests against with different distros/runtimes). |
…ubernetes controller-manager, scheduler and kube-proxy (kubernetes-sigs#153) * Set bind-address to 0.0.0.0 to be able to scrape metrics from kubernetes controller-manager and scheduler * Expose kube-proxy metrics * Fix comment * Remove indent funcion * Refactor * Improvement * Fix var type * Add quotes to permissions field value * Fix file reference * Fix permissions * Refactor * Refactor * escape character * Improve script * Refactor * Fix indentation * Fix script * fix script * Working in gpc * Add azure config * Fix azure template * Add scheduler and controller bindaddress for azure * Improve script * Improve script v2 * Improve script v3 * change ectd metrics --------- Co-authored-by: esierra-stratio <[email protected]> Co-authored-by: esierra-stratio <[email protected]>
We should theoretically be able to support:
and other similar container runtimes if someone has one they want, within the "node" containers.
Considerations:
@runcom was going to look into cri-o #151 (comment)
containerd should be pretty straighforward once we figure out how we want to handle a second runtime.
/kind feature
/priority important-longterm
/assign
/assign @runcom
The text was updated successfully, but these errors were encountered: