Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple CRI within the nodes #153

Closed
BenTheElder opened this issue Dec 6, 2018 · 9 comments
Closed

support multiple CRI within the nodes #153

BenTheElder opened this issue Dec 6, 2018 · 9 comments
Assignees
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@BenTheElder
Copy link
Member

We should theoretically be able to support:

  • docker
  • cri-o
  • containerd

and other similar container runtimes if someone has one they want, within the "node" containers.

Considerations:

  • should we install all of these in the base image? at what versions
  • we need some plumbing to select which one to use, inform kubeadm etc depending on the first point

@runcom was going to look into cri-o #151 (comment)

containerd should be pretty straighforward once we figure out how we want to handle a second runtime.

/kind feature
/priority important-longterm
/assign
/assign @runcom

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 6, 2018
@BenTheElder BenTheElder changed the title support other CRI within the nodes support multiple CRI within the nodes Dec 6, 2018
@BenTheElder BenTheElder added this to the 2019 goals milestone Dec 8, 2018
@tao12345666333
Copy link
Member

In my opinion, we don't need to install all of these in the base image.

We can have multiple types of base image by image tag. And choose one by a flag called CRI or others.

@BenTheElder
Copy link
Member Author

If we have a CRI flag it would have to just be in the base image, which might make kind create cluster less intuitive to select a CRI for most users since they'd need a node image built from a base image with the CRI.

There are some trade-offs with how many images we need to build and maintain, UX, image size, etc.

@tao12345666333
Copy link
Member

Yes.

If they are all installed to the base image, the image will become bigger.

I am very happy to participate in this.

@runcom
Copy link

runcom commented Jan 30, 2019

@mrunalp ptal as well

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 30, 2019
@neolit123
Copy link
Member

/lifecycle frozen
possibly needs evaluation if containerd is the only option forward at this point.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels May 30, 2019
@BenTheElder
Copy link
Member Author

CRI-O is feasible if someone can figure out how to do the image loading step reasonably.
Otherwise everything within the nodes is on CRI now.

/remove-lifecycle frozen
I'd rather let issues close eventually if there's no activity, regardless of the issue. They can always be re-opened.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 30, 2019
@BenTheElder BenTheElder added kind/design Categorizes issue or PR as related to design. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 15, 2019
@BenTheElder
Copy link
Member Author

[changed my mind on frozen for this issue... but moving to backlog as it's not really clear that varying CRIs on the nodes matters for cases kind is suited to, and this will introduce additional complexity]

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 6, 2020
@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 24, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 24, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 24, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 24, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 24, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 24, 2021
@BenTheElder
Copy link
Member Author

we've gotten rid of the lifecycling entirely in this repo for now, but, I still don't think this is the right thing for us to focus on. it does not enable more people to run kind or help people test their apps (portable k8s apps should NOT be aware of which CRI) and for testing kubernetes this is more appropriately done in the node_e2e testing (which involves individual VMs doing integration tests against with different distros/runtimes).

stg-0 pushed a commit to stg-0/kind that referenced this issue Aug 9, 2023
…ubernetes controller-manager, scheduler and kube-proxy (kubernetes-sigs#153)

* Set bind-address to 0.0.0.0 to be able to scrape metrics from kubernetes controller-manager and scheduler

* Expose kube-proxy metrics

* Fix comment

* Remove indent funcion

* Refactor

* Improvement

* Fix var type

* Add quotes to permissions field value

* Fix file reference

* Fix permissions

* Refactor

* Refactor

* escape character

* Improve script

* Refactor

* Fix indentation

* Fix script

* fix script

* Working in gpc

* Add azure config

* Fix azure template

* Add scheduler and controller bindaddress for azure

* Improve script

* Improve script v2

* Improve script v3

* change ectd metrics

---------

Co-authored-by: esierra-stratio <[email protected]>
Co-authored-by: esierra-stratio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants