-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: track empty domains separately in topology #959
Conversation
Tracking empty domains separately allows for more efficient anti-affinity checks when there are no empty domains. This is a frequent operation when doing a large scale up of a deployment with self anti-affinity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, tzneal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 7650057606
💛 - Coveralls |
Fixes #N/A
Description
Tracking empty domains separately allows for more efficient anti-affinity checks when there are no empty domains. This is a frequent operation when doing a large scale up of a deployment with self anti-affinity.
Using benchmarks with anti-affinity pods only, scheduling performance increases greatly:
How was this change tested?
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.