Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: track empty domains separately in topology #959

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jan 25, 2024

Fixes #N/A

Description

Tracking empty domains separately allows for more efficient anti-affinity checks when there are no empty domains. This is a frequent operation when doing a large scale up of a deployment with self anti-affinity.

Using benchmarks with anti-affinity pods only, scheduling performance increases greatly:

name               old pods/sec  new pods/sec  delta
Scheduling1-12        71.4 ±62%    304.0 ±13%  +326.11%  (p=0.008 n=5+5)
Scheduling50-12       49.2 ±12%    295.2 ± 3%  +499.63%  (p=0.008 n=5+5)
Scheduling250-12       236 ± 4%      455 ± 3%   +92.83%  (p=0.008 n=5+5)
Scheduling500-12       226 ± 7%      364 ± 1%   +61.51%  (p=0.008 n=5+5)
Scheduling1000-12     74.4 ± 4%    349.6 ± 1%  +370.05%  (p=0.008 n=5+5)
Scheduling2000-12     21.7 ± 1%    186.8 ± 1%  +759.80%  (p=0.016 n=5+4)

How was this change tested?

Unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Tracking empty domains separately allows for more efficient
anti-affinity checks when there are no empty domains.  This is
a frequent operation when doing a large scale up of a deployment
with self anti-affinity.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2024
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,tzneal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7650057606

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.37%

Totals Coverage Status
Change from base Build 7646651006: 0.02%
Covered Lines: 7738
Relevant Lines: 9628

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit a439f09 into main Jan 25, 2024
12 checks passed
@k8s-ci-robot k8s-ci-robot deleted the speed-up-anti-affinity branch January 25, 2024 05:14
engedaam pushed a commit to engedaam/karpenter-core that referenced this pull request Jan 25, 2024
engedaam pushed a commit to engedaam/karpenter-core that referenced this pull request Jan 25, 2024
engedaam pushed a commit to engedaam/karpenter-core that referenced this pull request Jan 25, 2024
engedaam pushed a commit to engedaam/karpenter-core that referenced this pull request Jan 25, 2024
engedaam pushed a commit to engedaam/karpenter-core that referenced this pull request Jan 29, 2024
jigisha620 pushed a commit to jigisha620/karpenter that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants