Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: RFC for disruption.terminationGracePeriod feature #834

Merged
merged 1 commit into from
Aug 12, 2024
Merged

docs: RFC for disruption.terminationGracePeriod feature #834

merged 1 commit into from
Aug 12, 2024

Conversation

wmgroot
Copy link
Contributor

@wmgroot wmgroot commented Dec 1, 2023 •
edited
Loading

Design for #743
Implementation PR: #916

Description
RFC for support for NodeClaim.spec.terminationGracePeriod (nodeDrainTimeout)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 1, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @wmgroot!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @wmgroot. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2023
@wmgroot wmgroot force-pushed the force-drain-design branch from b015c5c to 0ab6f41 Compare December 1, 2023 08:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 1, 2023
@jackfrancis
Copy link
Contributor

/test ls

@k8s-ci-robot
Copy link
Contributor

@jackfrancis: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

  • /test pull-karpenter-test-1-26
  • /test pull-karpenter-test-1-27
  • /test pull-karpenter-test-1-28
  • /test pull-karpenter-test-1-29

Use /test all to run all jobs.

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis
Copy link
Contributor

/test pull-karpenter-test-1-26

@jackfrancis
Copy link
Contributor

/test pull-karpenter-test-1-29

@k8s-ci-robot
Copy link
Contributor

@wmgroot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-karpenter-test-1-26 0ab6f41 link false /test pull-karpenter-test-1-26
pull-karpenter-test-1-29 0ab6f41 link false /test pull-karpenter-test-1-29

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jackfrancis
Copy link
Contributor

@wmgroot thank you for letting me pollute your PR thread w/ some prow tests, just testing out some recent additions, nothing for you to worry about here :)

njtran
njtran reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice design! Thanks for writing this out. Eager to talk more about this.

designs/disruption-controls-drain-timeout.md Outdated Show resolved Hide resolved
designs/disruption-controls-drain-timeout.md Outdated Show resolved Hide resolved
designs/disruption-controls-drain-timeout.md Outdated Show resolved Hide resolved
designs/disruption-controls-drain-timeout.md Outdated Show resolved Hide resolved
designs/disruption-controls-drain-timeout.md Outdated Show resolved Hide resolved
@wmgroot wmgroot force-pushed the force-drain-design branch from 0ab6f41 to e75de87 Compare December 6, 2023 08:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2023
@wmgroot wmgroot changed the title docs: RFC for disruption.forceDrainAfter feature docs: RFC for disruption.terminationGracePeriodSeconds feature Dec 6, 2023
@wmgroot wmgroot force-pushed the force-drain-design branch 2 times, most recently from 7186d87 to ddd9d38 Compare December 6, 2023 09:04
@wmgroot wmgroot force-pushed the force-drain-design branch from ddd9d38 to 42cc8c9 Compare December 6, 2023 19:17
@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2024
@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2024
@jmdeal
Copy link
Member

jmdeal commented May 16, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2024
@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2024
@github-actions github-actions bot closed this Jun 14, 2024
@wmgroot
Copy link
Contributor Author

wmgroot commented Jul 24, 2024

/reopen

@k8s-ci-robot
Copy link
Contributor

@wmgroot: Failed to re-open PR: state cannot be changed. The force-drain-design branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wmgroot
Copy link
Contributor Author

wmgroot commented Jul 24, 2024

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

@wmgroot: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wmgroot wmgroot force-pushed the force-drain-design branch from 6a4ac94 to 2321c07 Compare July 24, 2024 21:02
@github-actions github-actions bot removed lifecycle/closed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 25, 2024
jmdeal
jmdeal reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things to bring this inline with what we merged in #916, but other than that this looks good to go.

designs/nodeclaim-termination-grace-period.md Outdated Show resolved Hide resolved
designs/nodeclaim-termination-grace-period.md Outdated Show resolved Hide resolved
designs/nodeclaim-termination-grace-period.md Outdated Show resolved Hide resolved
@wmgroot wmgroot force-pushed the force-drain-design branch from 2321c07 to f66a230 Compare July 26, 2024 19:06
@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2024
njtran
njtran reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njtran, wmgroot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit e964a5d into kubernetes-sigs:main Aug 12, 2024
11 checks passed
@Bryce-Soghigian
Copy link
Member

great work!

BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Sep 16, 2024
@wmgroot @BEvgeniyS
docs: RFC for disruption.terminationGracePeriod feature (kubernetes-s…
4152a40 
…igs#834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garvinp-stripe garvinp-stripe garvinp-stripe left review comments

@jonathan-innis jonathan-innis jonathan-innis left review comments

@jmdeal jmdeal jmdeal left review comments

@sftim sftim sftim left review comments

@njtran njtran njtran left review comments

@ellistarn ellistarn ellistarn left review comments

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@njtran njtran

@jmdeal jmdeal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.