Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve log message when scheduling fails #192

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Feb 1, 2023

Fixes #

Description
Improves the log message when scheduling fails due to an unsatisfiable topology constraint.
How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tzneal tzneal requested a review from a team as a code owner February 1, 2023 16:06
@tzneal tzneal requested a review from engedaam February 1, 2023 16:06
@tzneal tzneal force-pushed the improve-log-for-unsat-topology-constraint branch from 9c0aac3 to 50fb850 Compare February 1, 2023 16:09
@coveralls
Copy link

coveralls commented Feb 1, 2023

Pull Request Test Coverage Report for Build 4066383096

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 79.585%

Files with Coverage Reduction New Missed Lines %
pkg/operator/controller/typed.go 2 93.55%
pkg/controllers/node/controller.go 4 73.53%
Totals Coverage Status
Change from base Build 4058997774: -0.1%
Covered Lines: 6370
Relevant Lines: 8004

💛 - Coveralls

Improves the log message when scheduling fails due to an unsatisfiable
topology constraint.
@tzneal tzneal force-pushed the improve-log-for-unsat-topology-constraint branch from 50fb850 to 0626262 Compare February 1, 2023 16:15
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzneal tzneal merged commit 23899c8 into kubernetes-sigs:main Feb 1, 2023
@tzneal tzneal deleted the improve-log-for-unsat-topology-constraint branch February 1, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants