fix: Ensure we keep observedGeneration up-to-date even when resource has completed

[jonathan-innis]

Fixes aws/karpenter-provider-aws#7494

Description

This ensures that we always set the observedGeneration for the status condition to the latest generation even for status conditions on NodeClaims that have already been marked as True.

NodeClaims with v1.0.8 Installed

➜  karpenter-provider-aws git:(main) k get nodeclaims
NAME            TYPE         CAPACITY    ZONE         NODE                                            READY   AGE
default-5x87w   c6gd.large   on-demand   us-west-2d   ip-192-168-98-14.us-west-2.compute.internal     True    83s
default-cmsrt   c6gd.large   on-demand   us-west-2a   ip-192-168-55-87.us-west-2.compute.internal     True    83s
default-hl8xp   c6gd.large   on-demand   us-west-2a   ip-192-168-142-174.us-west-2.compute.internal   True    83s
default-mfkxj   c6gd.large   on-demand   us-west-2b   ip-192-168-66-198.us-west-2.compute.internal    True    83s
default-w25n4   c6gd.large   on-demand   us-west-2d   ip-192-168-6-65.us-west-2.compute.internal      True    83s

NodeClaims after upgrade to v1.1.0

➜  karpenter-provider-aws git:(main) k get nodeclaims
NAME            TYPE         CAPACITY    ZONE         NODE                                            READY     AGE
default-5x87w   c6gd.large   on-demand   us-west-2d   ip-192-168-98-14.us-west-2.compute.internal     Unknown   3m31s
default-cmsrt   c6gd.large   on-demand   us-west-2a   ip-192-168-55-87.us-west-2.compute.internal     Unknown   3m31s
default-hl8xp   c6gd.large   on-demand   us-west-2a   ip-192-168-142-174.us-west-2.compute.internal   Unknown   3m31s
default-mfkxj   c6gd.large   on-demand   us-west-2b   ip-192-168-66-198.us-west-2.compute.internal    Unknown   3m31s
default-w25n4   c6gd.large   on-demand   us-west-2d   ip-192-168-6-65.us-west-2.compute.internal      Unknown   3m31s

NodeClaims after upgrading to this bugfix

➜  karpenter-provider-aws git:(main) k get nodeclaims
NAME            TYPE         CAPACITY    ZONE         NODE                                            READY   AGE
default-5x87w   c6gd.large   on-demand   us-west-2d   ip-192-168-98-14.us-west-2.compute.internal     True    6m14s
default-cmsrt   c6gd.large   on-demand   us-west-2a   ip-192-168-55-87.us-west-2.compute.internal     True    6m14s
default-hl8xp   c6gd.large   on-demand   us-west-2a   ip-192-168-142-174.us-west-2.compute.internal   True    6m14s
default-mfkxj   c6gd.large   on-demand   us-west-2b   ip-192-168-66-198.us-west-2.compute.internal    True    6m14s
default-w25n4   c6gd.large   on-demand   us-west-2d   ip-192-168-6-65.us-west-2.compute.internal      True    6m14s

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Pull Request Test Coverage Report for Build 12208520167

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 80.664%

---

Totals
Change from base Build 12203807145:	0.1%
Covered Lines:	8919
Relevant Lines:	11057

---

💛 - Coveralls

[engedaam]

/lgtm