Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lower casing disruption count metric on reason label #1862

Merged

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 3, 2024

Fixes #N/A

Description

  • Disruption metrics had a reason label that consisted of some upper case values and some lower case values. This PR will make them consistently lower case

How was this change tested?

  • Manually validated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2024
@engedaam engedaam changed the title fix: Lower casing for disruption metrics reason label fix: Lower casing disruption count metric on reason label Dec 3, 2024
@engedaam engedaam force-pushed the fix-casing-for-disruption-metrics branch 2 times, most recently from 4afb352 to 2d272b0 Compare December 3, 2024 17:42
@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12207947148

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.662%

Totals Coverage Status
Change from base Build 12203807145: 0.1%
Covered Lines: 8918
Relevant Lines: 11056

💛 - Coveralls

@engedaam
Copy link
Contributor Author

engedaam commented Dec 3, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2024
@engedaam engedaam force-pushed the fix-casing-for-disruption-metrics branch from 2d272b0 to 52a4c17 Compare December 7, 2024 00:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2024
@engedaam
Copy link
Contributor Author

engedaam commented Dec 7, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2024
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5531537 into kubernetes-sigs:main Dec 7, 2024
12 checks passed
@engedaam engedaam deleted the fix-casing-for-disruption-metrics branch December 11, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants