fix: hydration race for terminating nodes

[jmdeal]

Fixes #N/A

Description
Separates the hydration controller from the NodeClaim lifecycle controller since we need to ensure details are hydrated regardless of the lifecycle state of the NodeClaim. The motivating example for this change is Node's which were terminating during the upgrade. Since the hydration subreconciler only acted against non-terminating NodeClaims, the details would never get propagated to these Nodes leaving them orphaned after an upgrade.

How was this change tested?
make test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[coveralls]

Pull Request Test Coverage Report for Build 12092653837

Details

• 47 of 91 (51.65%) changed or added relevant lines in 4 files are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.3%) to 80.618%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controllers/controllers.go	0	2	0.0%
pkg/controllers/nodeclaim/hydration/controller.go	22	34	64.71%
pkg/utils/node/node.go	0	13	0.0%
pkg/controllers/node/hydration/controller.go	25	42	59.52%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/consolidation.go	4	88.55%

Totals
Change from base Build 12092434724:	-0.3%
Covered Lines:	8926
Relevant Lines:	11072

---

💛 - Coveralls

[jonathan-innis]

/lgtm
/approve

[jmdeal]

/hold

[engedaam]

/lgtm

[jonathan-innis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jmdeal, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jmdeal]

/unhold