Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Node Auto Repair #1768

Merged
merged 1 commit into from
Nov 8, 2024
Merged

RFC: Node Auto Repair #1768

merged 1 commit into from
Nov 8, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description
The purpose of this RFC is to Propose option around the best ways to support node auto repair for unhealthy Karpenter provisioned nodes. Related issue: #1659

How was this change tested?

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2024
@coveralls
Copy link

coveralls commented Oct 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11616209813

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 80.908%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 87.25%
Totals Coverage Status
Change from base Build 11603073442: 0.05%
Covered Lines: 8501
Relevant Lines: 10507
💛 - Coveralls

ellistarn
ellistarn reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
ellistarn
ellistarn reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
ellistarn
ellistarn reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
ellistarn
ellistarn reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
ellistarn
ellistarn reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
ellistarn
ellistarn reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
ellistarn
ellistarn reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
@njtran njtran mentioned this pull request Oct 22, 2024
Closed
njtran
njtran reviewed Oct 22, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
GnatorX
GnatorX reviewed Oct 24, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
GnatorX
GnatorX reviewed Oct 24, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the node-repair-rfc branch 3 times, most recently from 2c3ee55 to 8fb238b Compare October 28, 2024 17:56
jonathan-innis
jonathan-innis reviewed Oct 29, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
@engedaam engedaam changed the title RFC: Karpenter Node Auto Repair RFC: Node Auto Repair Oct 30, 2024
@engedaam engedaam mentioned this pull request Oct 30, 2024
Merged
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
jonathan-innis
jonathan-innis reviewed Nov 7, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the node-repair-rfc branch 10 times, most recently from adfa039 to b449159 Compare November 7, 2024 22:17
jonathan-innis
jonathan-innis reviewed Nov 8, 2024
View reviewed changes
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
designs/node-repair.md Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 650bf3d into kubernetes-sigs:main Nov 8, 2024
12 checks passed
engedaam added a commit to engedaam/karpenter-core that referenced this pull request Nov 10, 2024
@engedaam
RFC: Node Auto Repair (kubernetes-sigs#1768)
92e3d08
@engedaam engedaam deleted the node-repair-rfc branch December 11, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn left review comments

@GnatorX GnatorX GnatorX left review comments

@njtran njtran njtran left review comments

@mariuskimmina mariuskimmina mariuskimmina left review comments

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@engedaam @coveralls @k8s-ci-robot @ellistarn @GnatorX @njtran @jonathan-innis @mariuskimmina @Bryce-Soghigian