fix: handle NodeClaim termination in the lifecycle controller #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
jmdeal
force-pushed
the
refactor/nc-lifecycle-finalization
branch
from
23aec59 to
a114269
Compare
jmdeal
force-pushed
the
refactor/nc-lifecycle-finalization
branch
from
a114269 to
490dc69
Compare
jmdeal
force-pushed
the
refactor/nc-lifecycle-finalization
branch
from
490dc69 to
ed92d2d
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmdeal, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Pull Request Test Coverage Report for Build 11096184653Details
💛 - Coveralls |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
jeevanpuchakay
pushed a commit
to jeevanpuchakay/karpenter
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Collapses the NodeClaim termination and lifecycle controllers. This eliminates a race where the termination controller may finalize a NodeClaim while the lifecycle controller is launching an instance, resulting in an instance leak. The garbage collection controller ensures that this leaked instance is cleaned up, but this prevents the leak from occurring in the first place.
How was this change tested?
make presubmitand E2Es in karpenter-provider-aws (TODO)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.