-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure all patch calls can conflict when resource version doesn't match #1658
fix: Ensure all patch calls can conflict when resource version doesn't match #1658
Conversation
Skipping CI for Draft Pull Request. |
a630780
to
3c02c33
Compare
Pull Request Test Coverage Report for Build 10908544791Details
💛 - Coveralls |
3c02c33
to
b0c3dcf
Compare
b93f1a1
to
d7a48c3
Compare
d7a48c3
to
25271dc
Compare
25271dc
to
4e6c7ae
Compare
4e6c7ae
to
e4ea0d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1578
Description
This change ensures that calls to Patch that would fully replace portions of the spec like lists continue to conflict if the resource has changed since the controller first retrieved the resource.
This fixes the issue in #1578 where resource quantities are converted to different strings during deserialization and then re-serialization back by ensuring that the request that we send to the apiserver only represents the parts of the resource that we intend to change.
This allows us to keep the NodeClaim immutability checks that we have.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.