Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable copyloopvar in linter #1589

Merged
merged 2 commits into from
Aug 21, 2024
Merged

ci: Enable copyloopvar in linter #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca39c15
Enable copyloopvar in linter
jonathan-innis Aug 21, 2024
4aebe7d
Fix unneccesary copied variables
jonathan-innis Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ linters:
- asciicheck
- bidichk
- errorlint
- exportloopref
- copyloopvar
- gosec
- revive
- stylecheck
Expand Down
2 changes: 0 additions & 2 deletions test/pkg/environment/common/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ func (m *Monitor) DeletedNodes() []*corev1.Node {
func (m *Monitor) PendingPods(selector labels.Selector) []*corev1.Pod {
var pods []*corev1.Pod
for _, pod := range m.poll().pods.Items {
pod := pod
if pod.Status.Phase != corev1.PodPending {
continue
}
Expand All @@ -154,7 +153,6 @@ func (m *Monitor) PendingPodsCount(selector labels.Selector) int {
func (m *Monitor) RunningPods(selector labels.Selector) []*corev1.Pod {
var pods []*corev1.Pod
for _, pod := range m.poll().pods.Items {
pod := pod
if pod.Status.Phase != corev1.PodRunning {
continue
}
Expand Down
Loading