Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cloudprovider specific Eventual disruption methods #1588

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat: add cloudprovider specific Eventual disruption methods #1588

merged 5 commits into from
Aug 28, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Add eventual disruption methods that will consist of drift and cloud provider supplied disruption
  • The objective is to allow a cloudproviders to update the status on a nodeclaim with a disruptionReasons and the disruption controller to orchestrate the termination and replacement of the nodeclaim
  • User will be able to block on the disruption type provided by the cloudprovider in their disruption controls on the nodepool.

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2024
@coveralls
Copy link

coveralls commented Aug 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10588242890

Details

  • 67 of 71 (94.37%) changed or added relevant lines in 9 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 78.285%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/nodepool.go 7 8 87.5%
pkg/controllers/disruption/helpers.go 10 11 90.91%
pkg/controllers/disruption/controller.go 22 24 91.67%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/controller.go 2 66.47%
pkg/controllers/disruption/events/events.go 11 88.66%
Totals Coverage Status
Change from base Build 10584197214: -0.1%
Covered Lines: 8634
Relevant Lines: 11029
💛 - Coveralls

jonathan-innis
jonathan-innis reviewed Aug 23, 2024
View reviewed changes
pkg/apis/v1/nodepool.go Show resolved Hide resolved
pkg/controllers/disruption/controller.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/controller.go Outdated Show resolved Hide resolved
pkg/apis/v1/nodepool.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/eventual.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/eventual.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the eventual-disruption branch from fe23156 to 32ce9a9 Compare August 23, 2024 19:32
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2024
@engedaam engedaam force-pushed the eventual-disruption branch 2 times, most recently from 5b96de6 to e19a525 Compare August 23, 2024 20:17
@engedaam engedaam force-pushed the eventual-disruption branch 3 times, most recently from be8c18e to cf24c45 Compare August 26, 2024 15:34
@engedaam engedaam marked this pull request as ready for review August 26, 2024 15:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tallaxes August 26, 2024 15:35
@engedaam engedaam force-pushed the eventual-disruption branch from cf24c45 to 09c5f1d Compare August 26, 2024 15:43
jonathan-innis
jonathan-innis reviewed Aug 26, 2024
View reviewed changes
pkg/apis/v1/nodepool.go Outdated Show resolved Hide resolved
pkg/cloudprovider/fake/cloudprovider.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/controller.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/eventual.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the eventual-disruption branch 4 times, most recently from ec32d26 to 4b5b921 Compare August 26, 2024 23:43
@engedaam engedaam force-pushed the eventual-disruption branch 2 times, most recently from 36ecde4 to bd45d05 Compare August 27, 2024 00:05
@engedaam engedaam force-pushed the eventual-disruption branch 2 times, most recently from f40d1d3 to 0d726ab Compare August 27, 2024 05:17
@engedaam engedaam force-pushed the eventual-disruption branch 4 times, most recently from 6b7a896 to 83c7f55 Compare August 27, 2024 21:41
jonathan-innis
jonathan-innis reviewed Aug 27, 2024
View reviewed changes
pkg/apis/v1/nodepool.go Show resolved Hide resolved
pkg/controllers/disruption/controller.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/controller.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/controller.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/controller.go Outdated Show resolved Hide resolved
pkg/controllers/disruption/eventual.go Show resolved Hide resolved
pkg/controllers/disruption/eventual.go Show resolved Hide resolved
pkg/controllers/disruption/eventual_test.go Outdated Show resolved Hide resolved
test/suites/perf/disruption_test.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the eventual-disruption branch from ae859fc to b21cb0a Compare August 27, 2024 22:57
@engedaam engedaam force-pushed the eventual-disruption branch from b21cb0a to 1595ce0 Compare August 27, 2024 23:00
jonathan-innis
jonathan-innis approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@jonathan-innis
Copy link
Member

Nice work!

@k8s-ci-robot k8s-ci-robot merged commit 375bced into kubernetes-sigs:main Aug 28, 2024
11 checks passed
@jonathan-innis jonathan-innis mentioned this pull request Aug 28, 2024
Closed
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Sep 16, 2024
@engedaam @jonathan-innis @BEvgeniyS
feat: add cloudprovider specific Eventual disruption methods (kuberne…
c930d0c 
…tes-sigs#1588)

Co-authored-by: Jonathan Innis <[email protected]>
@engedaam engedaam deleted the eventual-disruption branch December 11, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@jmdeal jmdeal Awaiting requested review from jmdeal

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@engedaam @k8s-ci-robot @coveralls @jonathan-innis