Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: implement nodeclaim.spec.terminationGracePeriod CEL tests #1427

Merged
merged 1 commit into from
Jul 18, 2024
Merged

test: implement nodeclaim.spec.terminationGracePeriod CEL tests #1427

merged 1 commit into from
Jul 18, 2024

Conversation

wmgroot
Copy link
Contributor

@wmgroot wmgroot commented Jul 15, 2024

Description
Implements CEL tests for the new terminationGracePeriod field on NodeClaim.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot requested review from engedaam and jmdeal July 15, 2024 23:51
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @wmgroot. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2024
@wmgroot wmgroot force-pushed the nodeclaim-tgp-cel-test branch 2 times, most recently from 888568b to c07a42a Compare July 15, 2024 23:54
@wmgroot wmgroot changed the title chore: implement nodeclaim.spec.terminationGracePeriod CEL tests test: implement nodeclaim.spec.terminationGracePeriod CEL tests Jul 16, 2024
@wmgroot wmgroot force-pushed the nodeclaim-tgp-cel-test branch from c07a42a to 7ea842c Compare July 16, 2024 01:42
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
@wmgroot wmgroot force-pushed the nodeclaim-tgp-cel-test branch from 7ea842c to 98c503c Compare July 16, 2024 02:04
njtran
njtran reviewed Jul 16, 2024
View reviewed changes
pkg/apis/v1/nodeclaim.go Outdated Show resolved Hide resolved
@wmgroot wmgroot force-pushed the nodeclaim-tgp-cel-test branch from 98c503c to 7784e76 Compare July 16, 2024 21:31
@coveralls
Copy link

coveralls commented Jul 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9983338945

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 78.126%
Totals Coverage Status
Change from base Build 9982597534: 0.02%
Covered Lines: 8836
Relevant Lines: 11310
💛 - Coveralls

@wmgroot wmgroot force-pushed the nodeclaim-tgp-cel-test branch from e89df0e to c09227b Compare July 17, 2024 18:19
njtran
njtran reviewed Jul 17, 2024
View reviewed changes
kwok/charts/crds/karpenter.sh_nodeclaims.yaml Outdated
@@ -267,6 +267,7 @@ spec:

The feature can also be used to allow maximum time limits for long-running jobs which can delay node termination with preStop hooks.
If left undefined, the controller will wait indefinitely for pods to be drained.
pattern: ^([0-9]+(\\.[0-9]+)?(s|m|h))+$
Copy link
Contributor

@njtran njtran Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the middle bit?

Suggested change
pattern: ^([0-9]+(\\.[0-9]+)?(s|m|h))+$
pattern: ^([0-9]+(s|m|h))+$

@wmgroot wmgroot force-pushed the nodeclaim-tgp-cel-test branch from c09227b to 6086cc5 Compare July 18, 2024 00:19
njtran
njtran reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for the commit!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njtran, wmgroot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 68561e8 into kubernetes-sigs:main Jul 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@engedaam engedaam Awaiting requested review from engedaam

@jmdeal jmdeal Awaiting requested review from jmdeal

Assignees

@njtran njtran

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wmgroot @k8s-ci-robot @coveralls @njtran