feat: Set default values on the APIVersion and Kind on the nodeClassRef

[engedaam]

Fixes #N/A

Description

• Add GetNodeClassGVK to the cloudprovider interface
• The cloudprovider will give the APIVersion and Kind of the NodeClass that is supported by the provider. Karpenter will default all NodePools to the APIVersion and Kind, given by the provider, inside of each nodeClassRef.
• To avoid a breaking change, we will use the hash controller to set the APIVersion and Kind at runtime.
• The team is considering on making all fields on the nodeClassRef required at v1, which will allow us to drop the defaulting behavior.
• Related to issue: How to handle unset apiVersion and kind in nodeClassRef #909

How was this change tested?

• make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: engedaam
Once this PR has been reviewed and has the lgtm label, please assign bwagner5 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Pull Request Test Coverage Report for Build 8472762287

Details

• 22 of 26 (84.62%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.08%) to 79.016%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controllers/controllers.go	0	1	0.0%
kwok/cloudprovider/cloudprovider.go	0	3	0.0%

Totals
Change from base Build 8456314668:	0.08%
Covered Lines:	8288
Relevant Lines:	10489

---

💛 - Coveralls

[engedaam]

/hold

We need to make sure that this PR is merged in after drift hash versioning have been released. Issue: #957

[engedaam]

/test all

[k8s-ci-robot]

@engedaam: No jobs can be run with /test all.
The following commands are available to trigger optional jobs:

• /test pull-karpenter-test-1-26
• /test pull-karpenter-test-1-27
• /test pull-karpenter-test-1-28
• /test pull-karpenter-test-1-29

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[engedaam]

/remove-hold

[njtran]

I was thinking here, should we make it required, or should we make it optional and just require that cloud providers add the defaulting logic to include the GVK into NodePools? If we require it, we can't default it. Is there a point in allowing users to be wrong here?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jonathan-innis]

@engedaam Given that we are punting on setting the default GVK and we have already merged in the CloudProvider changes to allow for shorter reconciles, do we need to keep this PR open? I think if we were to make this change down-the-line, it would most likely take the form of something in our conversion webhooks

[engedaam]

Closing for now. We plan on handling defaults for the APIVersion and Kind as part of the conversion webhooks at v1.