Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing knative logger to controller-runtime injected logger #922

Closed
jonathan-innis opened this issue Jan 3, 2024 · 2 comments · Fixed by #1050
Closed

Migrate existing knative logger to controller-runtime injected logger #922

jonathan-innis opened this issue Jan 3, 2024 · 2 comments · Fixed by #1050
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@jonathan-innis
Copy link
Member

Description

Controller runtime already gives us a lot of structured values that are injected into the logger that is used in the Reconcile context by default. We should consider moving over to use this logger instead of our existing logging.FromContext which leverages knative-style initialization but doesn't give us a lot of the values that controller runtime already gives us for free.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 3, 2024
@fmuyassarov
Copy link
Member

Hey @jonathan-innis
If you don't mind I would like to help with this task.

@fmuyassarov
Copy link
Member

Hey @jonathan-innis If you don't mind I would like to help with this task.

I have added #1050. But there are still things I need to test my changes about which I'm not sure yet how but will try to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants