Remove references to knative.dev/pkg

[jonathan-innis]

Tell us about your request

Right now, we are using various libraries and utilities in knative.dev/pkg. We should knock out references to knative.dev/pkg to not depend on that package directly by removing the following uses for it:

• Initializing our logger and configuring a dynamic watch on the zap-config
• Leveraging the knative logger with logging.FromContext rather than using the default controller-runtime logger: Migrate existing knative logger to controller-runtime injected logger #922
• Setting up our webhook server for webhook requests
• Dynamically reconciling webhook certificates in the MutatingWebhookConfigurations
• StatusConditions operations on Custom Resources (Machines) in the project

We'd like to move away from having direct reliance on knative.dev/pkg. This library has bottlenecked our ability to upgrade to the latest client packages of client-go, which may eventually bottleneck Karpenter's ability to support newer versions of K8s as APIs evolve.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

N/A

Are you currently working around this issue?

N/A

Additional Context

No response

Attachments

No response

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[sftim]

Also,

karpenter/pkg/apis/crds/karpenter.sh_nodeclaims.yaml

Line 325 in 48d8ee3

description: 'Condition defines a readiness condition for a Knative resource. See: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties'

mentions KNative - perhaps as a side-effect?

[jonathan-innis]

We should migrate the logger that is being initialized through knative-style functions to use the default controller-runtime logger that is injected into the controller Reconcile context by default: #922

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Bryce-Soghigian]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[liangyuanpeng]

/lifecycle frozen