Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize ip-masq-agent codebase #75

Merged
merged 1 commit into from
May 2, 2022
Merged

Modernize ip-masq-agent codebase #75

merged 1 commit into from
May 2, 2022

Conversation

jingyuanliang
Copy link
Contributor

@jingyuanliang jingyuanliang commented Apr 30, 2022 •
edited
Loading

  • Removed Godeps
  • Updated build script from thockin/go-build-template
  • Updated to Golang 1.17
  • Updated base image to bullseye-v1.3.0
  • Updated Kubernetes dependency to v1.23.6
  • Updated ip-masq-agent.yaml to match registry in Makefile
  • Executed go mod tidy and go mod vendor

--

ip-masq-agent.yaml is now using tag v2.6.2 which does not exist yet. Please tag v2.6.2 after merging this PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @jingyuanliang!

It looks like this is your first PR to kubernetes-sigs/ip-masq-agent 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ip-masq-agent has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from MrHohn and mtaufen April 30, 2022 05:05
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 30, 2022
@jingyuanliang
Copy link
Contributor Author

/assign mrhohn

@jingyuanliang
Modernize ip-masq-agent codebase
05d01d7 
* Removed Godeps
* Updated build script from thockin/go-build-template
* Updated to Golang 1.17
* Updated base image to bullseye-v1.3.0
* Updated Kubernetes dependency to v1.23.6
* Updated ip-masq-agent.yaml to match registry in Makefile
* Executed `go mod tidy` and `go mod vendor`
MrHohn
MrHohn approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0fe776e into kubernetes-sigs:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingyuanliang @k8s-ci-robot @MrHohn