Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace k8s.gcr.io with registry.k8s.io #120

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 6, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR replaces all k8s.gcr.io references with registry.k8s.io. See the linked issue for more details.

Which issue(s) this PR fixes:
xref kubernetes/k8s.io#4738

Release note:

Replace all `k8s.gcr.io` references with `registry.k8s.io`

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2023
@coveralls
Copy link

Coverage Status

Coverage: 83.952%. Remained the same when pulling 0d2f3b1 on xmudrii:registry-k8s-io into 58fa16b on kubernetes-sigs:master.

@ambiknai
Copy link
Contributor

ambiknai commented Mar 6, 2023

Hi @xmudrii
Does the image get automatically pushed to registry.k8s.io hence forth when we create a release tag or should we raise PR for that in k8s.io repository

@xmudrii
Copy link
Member Author

xmudrii commented Mar 6, 2023

@ambiknai If you already push to k8s.gcr.io, then your images will be available under registry.k8s.io automatically. You can find more details about how registry.k8s.io works in the project repo.

@ambiknai
Copy link
Contributor

ambiknai commented Mar 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ambiknai, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 66eb5a5 into kubernetes-sigs:master Mar 7, 2023
@xmudrii xmudrii deleted the registry-k8s-io branch March 7, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants