Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: image version matching #99

Merged

Conversation

rakshitgondwal
Copy link
Member

@rakshitgondwal rakshitgondwal commented Jan 16, 2024

Description

Fixes #94

Adds the functionality to automatically set the conformance image version to match the k8s cluster version by default.
A user can still explicitly define an image using --conformance-image flag if they want to.

Screenshots

Default behavior. Automatically fetches the image according to the cluster version, i.e v1.27.3:

Screenshot from 2024-01-17 23-01-52

Behavior if --conformance-image has been defined. In this case v1.29.0:

Screenshot from 2024-01-17 23-12-08

Signed-off-by: Rakshit Gondwal <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rakshitgondwal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2024
pkg/common/args.go Outdated Show resolved Hide resolved
pkg/common/const.go Show resolved Hide resolved
pkg/common/args.go Outdated Show resolved Hide resolved
@rjsadow
Copy link
Collaborator

rjsadow commented Jan 16, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
main.go Outdated Show resolved Hide resolved
@rakshitgondwal rakshitgondwal marked this pull request as ready for review January 17, 2024 17:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Jan 17, 2024

/approve

This looks great! I want to take a few minutes to test it myself before putting on an lgtm. I'll make some time this afternoon to verify it.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rakshitgondwal, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@rakshitgondwal
Copy link
Member Author

Sure, thanks @rjsadow
What does the failing test mean though?

@rjsadow
Copy link
Collaborator

rjsadow commented Jan 17, 2024

@rjsadow
Copy link
Collaborator

rjsadow commented Jan 17, 2024

looks good to me @rakshitgondwal, let's fix the go fmt issue then I'll lgtm.

Signed-off-by: Rakshit Gondwal <[email protected]>
@rakshitgondwal
Copy link
Member Author

Fixed, please check @rjsadow

@rjsadow
Copy link
Collaborator

rjsadow commented Jan 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9be175e into kubernetes-sigs:main Jan 17, 2024
7 checks passed
@rakshitgondwal
Copy link
Member Author

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Version Matching
3 participants