-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to customize the namespace #139
Conversation
add a new flag to set a custom namespace - no impact for existing users, because we keep the same default value Signed-off-by: Vincent Behar <[email protected]>
Hi @vbehar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Please fix the merge conflicts @vbehar |
pkg/common/const.go
Outdated
@@ -19,8 +19,8 @@ package common | |||
const ( | |||
// busyboxImage is the image used to extract the e2e logs | |||
busyboxImage = "registry.k8s.io/e2e-test-images/busybox:1.36.1-1" | |||
// Namespace is the namespace where the conformance pod is created | |||
Namespace = "conformance" | |||
// namespace is the namespace where the conformance pod is created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would prefer it to be named 'Namespace' since we are utilizing 'namespace' as a variable within the code as well, just to maintain differentiation as a constant value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I changed it to lowercase to avoid the public visibility, and other packages using it instead of the user-provided namespace. But maybe I can change it to DefaultNamespace
to make it clear...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjsadow, vbehar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add a new
--namespace
flag to set a custom namespace - no impact for existing users, because we keep the same default value