Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSI Spec dependency to v1.0.0-rc2 #159

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Update CSI Spec dependency to v1.0.0-rc2 #159

merged 2 commits into from
Nov 15, 2018

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Nov 14, 2018 •
edited by saad-ali
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2018
@davidz627
Copy link
Contributor Author

davidz627 commented Nov 14, 2018 •
edited
Loading

/hold

Needs to be updated again after csi-test and external components are cut

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2018
saad-ali
saad-ali requested changes Nov 14, 2018
View reviewed changes
pkg/common/utils.go Outdated Show resolved Hide resolved
pkg/gce-pd-csi-driver/controller.go Show resolved Hide resolved
pkg/gce-pd-csi-driver/controller.go Show resolved Hide resolved
@davidz627
Copy link
Contributor Author

@saad-ali resolved your comments

saad-ali
saad-ali approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jingxu97 @xing-yang This breaks the snapshot implementation. We will need a follow up PR to fix that.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@davidz627
Copy link
Contributor Author

I don't think the snapshot implementation is broken, I've done a small refactor to ensure that it works with the new spec. @jingxu97 @xing-yang can verify at some later point

@saad-ali
Copy link
Contributor

@davidz627 Got it, thanks for the clarification.

@davidz627
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2018
@msau42
Copy link
Contributor

msau42 commented Nov 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1f306b0 into kubernetes-sigs:master Nov 15, 2018
@davidz627 davidz627 deleted the feature/csi10 branch November 15, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@msau42 msau42 Awaiting requested review from msau42

Assignees

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidz627 @k8s-ci-robot @saad-ali @msau42