-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opentelemetry tracing on gRPC calls for self-managed drivers #1403
Add opentelemetry tracing on gRPC calls for self-managed drivers #1403
Conversation
Welcome @Fricounet! |
Hi @Fricounet. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @mattcary, I finally got the time to submit the PR |
fd7e938
to
27757c7
Compare
@mattcary could you take a look at this PR? 🙏 |
Sorry for the delay in looking at this, we got backed up behind some issues. I'll take a look. |
/lgtm I'll probably need to re-lgtm after you resolve the merge conflict. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fricounet, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
27757c7
to
485bf1d
Compare
thanks for your review, I just rebased the PR :) |
Otel tracing can be enabled using the flag `--enable-otel-tracing` which will provide a basic instrumentation of the gRPC calls received by the driver.
485bf1d
to
99c130e
Compare
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow self-managed drivers to add basic tracing on the gRPC calls received by the driver (controller and node) using opentelemetry. This is useful to help monitor and debug driver issues on top of existing logs.
Otel tracing can be enabled using the flag
--enable-otel-tracing
. Defaults tofalse
.Which issue(s) this PR fixes:
Fixes #1299
Special notes for your reviewer:
Does this PR introduce a user-facing change?: